Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-https] Fix decoding of gzip responses #13605

Merged
2 commits merged into from
Feb 5, 2021
Merged

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Feb 4, 2021

#13266 accidentally flipped a boolean, causing gzip responses to not be properly decoded. This PR fixes the issue and changes the code to make it less convoluted.

Also fixes the version string used by the User-Agent policy and finishes removing some old API surface that #13266 forgot to clean up.

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Feb 4, 2021
@xirzec xirzec requested a review from jeremymeng February 4, 2021 23:09
@xirzec xirzec requested a review from ramya-rao-a as a code owner February 4, 2021 23:09
@xirzec xirzec self-assigned this Feb 4, 2021
@ghost
Copy link

ghost commented Feb 4, 2021

Hello @xirzec!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xirzec
Copy link
Member Author

xirzec commented Feb 5, 2021

/check-enforcer reset

@xirzec
Copy link
Member Author

xirzec commented Feb 5, 2021

/check-enforcer evaluate

@ghost ghost merged commit e5af5c2 into Azure:master Feb 5, 2021
@xirzec xirzec deleted the fixGzipResponses branch February 5, 2021 00:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants