[DO NOT MERGE] Adding claims parameter to GetTokenOptions #13595
Conversation
ghost
added
the
| /** | ||
| * Additional claims to be included in the token. See {@link https://openid.net/specs/openid-connect-core-1_0-final.html#ClaimsParameter} for more information on format and content. | ||
| */ | ||
| claims?: string; |
There was a problem hiding this comment.
Since CAE has been pushed out of the current milestone, am guessing this is not needed for the Feb release? @sadasant Let's make sure @azure/core-auth is released before merging this PR
There was a problem hiding this comment.
I am not sure if this needs to be released or not. It seemed like it needed to be released. @schaabs please confirm.
There was a problem hiding this comment.
It needs to be released before we can release any CAE support in core-http or identity. So it doesn't have to be released now, but if not we'll need to include this with our out of band releases for CAE support. All that said, I don't see any harm in releasing it now.
|
Added @ellismg since he's waiting for core-auth to be released to use it on eventgrid. |
There was a problem hiding this comment.
Assuming that @ramya-rao-a is happy with the plan of record of including this, the code change itself LGTM.
For the record, EventGrid is indifferent on if this included in the release or not, but we do need the SAS stuff that landed earlier, so I'm 100% fine if you also hold off on this and then do some out of band release with the CAE stuff later.
There was a problem hiding this comment.
CAE support would be in beta, and we are yet to discuss whether core-auth would ship a beta or a patch/minor update to support the CAE features. So, my recommendation would be to release the core-auth from the master branch so that Event Grid is unblocked, and then have an out of band release for core-auth as per CAE requirements
Adding a "request changes" to this PR to hold off on the PR merge until core-auth is released
sadasant
changed the title
|
Closed on favor of: #13888 |
Revert "[Management Plane][Azure Search] Adding new API version 2021-01-04. (Azure#13355)" (Azure#13595) This reverts commit 5c2185adda8aa915a391ae182c1f02cc587f4f79.
Adding the optional claims parameter to getToken to support CAE claims challenges and additional claims.