-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casing issue in arm-synapse files #13493
Conversation
/azp run js - mgmt - pr |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but please get somebody from the arm-synapse team to approve 🌞
@colawwj : Can you please have a look at this PR? This is to fix build break in mgmt - pr pipeline. Logs here: |
Should we bump the package version ? |
@qiaozha @colawwj I believe current version is not yet released. Do we still need to bump package version? |
The last change to this package was in #13434 which should have auto published the package. Are we saying that the auto publish failed due to the build break which in turn was due to the casing issue here? @qiaozha, Also, this is a purely auto generated package and should not ideally have manual changes. Do we know how the casing issue got introduced? cc @colawwj who create the last PR for this package |
This issue is caused by git insensitive of file name case change. The actually change should be made to fix this issue is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't merge this PR because of the actual changes needed which is based on latest swagger
@colawwj Can you submit another PR to fix this issue? Thanks |
fixed by #13535 and the release pipeline is working again. a newer version of @azure/arm-synapse sdk is out here. https://www.npmjs.com/package/@azure/arm-synapse/v/5.0.0 |
add go sdk config for apimanagement (Azure#13493)
Fix build break in management pr pipeline