Samples and tests for Azure Quantum SDK #13480
Conversation
|
/azp run js - mgmt - pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to feature/azure-quantum-sdk
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - quanttum - ci |
|
No pipelines are associated with this pull request. |
|
/azp run net - quantum - ci |
|
No pipelines are associated with this pull request. |
|
/azp run js - quantum - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - quantum - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…azure-sdk-for-js into harshan/quantum-jobs-build-failure
…to harshan/quantum-jobs-build-failure
Co-authored-by: Harsha Nalluru <[email protected]>
|
/azp run js - quantum - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…azure-sdk-for-js into harshan/quantum-jobs-build-failure
…o out of memory exception
| "execute:samples": "npm run build:samples && dev-tool samples run dist-samples/javascript dist-samples/typescript/dist/dist-samples/typescript/src/", | ||
| "extract-api": "tsc -p . && api-extractor run --local", | ||
| "format": "prettier --write --config ../../.prettierrc.json --ignore-path ../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | ||
| "integration-test:browser": "echo skipped", |
There was a problem hiding this comment.
Browser tests are being skipped because we would need to launch the browser pop-up window for authentication and it couldn't be possible to do that with a headless browser.
/cc @sadasant
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "name": "azure-quantum-jobs-samples-js", | |||
There was a problem hiding this comment.
Regarding samples... restructuring required in a future PR.
The current structure we have for samples folder - https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/template/template/samples
JS and TS samples are to be separated in folders as shown in the above link.
Based on the metadata in the readme of those folders, the samples get published at docs.microsoft.com
Example: https://docs.microsoft.com/en-us/samples/azure/azure-sdk-for-js/service-bus-typescript/
| subscriptionId: string, | ||
| resourceGroupName: string, | ||
| workspaceName: string, | ||
| options?: QuantumJobClientOptionalParams | ||
| ) { | ||
| if (credentials === undefined) { |
There was a problem hiding this comment.
| if (credentials === undefined) { | |
| if (credentials == undefined) { |
This would cover both null and undefined.
There was a problem hiding this comment.
this code is auto-generated by autorest so I'll open a bug there
vxfield
dismissed
sarangan12’s stale review
Will remove this file in the next PR
No description provided.