[test-utils-recorder] Refactor to separate node/browser codepaths

common/tools/dev-tool/package.json

@@ -64,8 +64,6 @@
     "mocha": "^7.1.1",
     "rimraf": "^3.0.0",
     "rollup": "^1.16.3",
-    "rollup-plugin-node-builtins": "~2.1.2",
-    "rollup-plugin-node-globals": "~1.4.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
     "rollup-plugin-visualizer": "^4.0.4"
   }

common/tools/dev-tool/src/config/rollup.base.config.ts

@@ -5,8 +5,6 @@ import cjs from "@rollup/plugin-commonjs";
 import sourcemaps from "rollup-plugin-sourcemaps";
 import multiEntry from "@rollup/plugin-multi-entry";
 import json from "@rollup/plugin-json";
-import nodeBuiltinsPlugin from "rollup-plugin-node-builtins";
-import nodeGlobals from "rollup-plugin-node-globals";
 
 import nodeBuiltins from "builtin-modules";
 
@@ -19,6 +17,12 @@ interface PackageJson {
 
 // #region Warning Handler
 
+/**
+ * A function that can determine whether a rollupwarning should be ignored. If
+ * the function returns `true`, then the warning will not be displayed.
+ */
+export type WarningInhibitor = (warning: RollupWarning) => boolean;
+
 function ignoreNiseSinonEvalWarnings(warning: RollupWarning): boolean {
   return (
     warning.code === "EVAL" &&
@@ -58,33 +62,31 @@ function makeBrowserTestConfig() {
   const config: RollupOptions = {
     input: {
       include: ["dist-esm/test/**/*.spec.js"],
-      exclude: ["dist-esm/test/**/node/*.spec.js"]
+      exclude: ["dist-esm/test/**/node/**"]
     },
     output: {
       file: `dist-test/index.browser.js`,
       format: "umd",
-      sourcemap: true,
-      globals: { "fs-extra": "undefined" }
+      sourcemap: true
     },
     preserveSymlinks: false,
-    // fs-extra must be marked as external in order to avoid an initialization error
-    external: ["fs-extra"],
     plugins: [
       multiEntry({ exports: false }),
       nodeResolve({
-        mainFields: ["module", "browser"],
-        preferBuiltins: true
+        mainFields: ["module", "browser"]
       }),
       cjs({
         namedExports: {
-          chai: ["assert", "use"],
+          // Chai's strange internal architecture makes it impossible to statically
+          // analyze its exports.
+          chai: ["version", "use", "util", "config", "expect", "should", "assert"],
+          // OpenTelemetry uses an __exportStar downleveled helper function to
+          // declare its exports, and so we have to add them here as well.
           "@opentelemetry/api": ["CanonicalCode", "SpanKind", "TraceFlags"]
         }
       }),
       json(),
-      sourcemaps(),
-      nodeGlobals(),
-      nodeBuiltinsPlugin()
+      sourcemaps()
       //viz({ filename: "dist-test/browser-stats.html", sourcemap: true })
     ],
     onwarn: makeOnWarnForTesting(),
@@ -95,8 +97,6 @@ function makeBrowserTestConfig() {
     treeshake: false
   };
 
-  // (config.external as string[]).push(...Object.keys(pkg.devDependencies));
-
   return config;
 }
 

sdk/formrecognizer/ai-form-recognizer/test/utils/recordedClients.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT license.
 
 import { Context } from "mocha";
-import * as dotenv from "dotenv";
 
 import {
   env,
@@ -16,8 +15,6 @@ import { AzureKeyCredential, FormTrainingClient, FormRecognizerClient } from "..
 import { ClientSecretCredential } from "@azure/identity";
 import { TokenCredential } from "@azure/core-auth";
 
-dotenv.config();
-
 export interface RecordedTrainingClient {
   client: FormTrainingClient;
   recorder: Recorder;

sdk/metricsadvisor/ai-metrics-advisor/test/public/adminclient.spec.ts

@@ -3,9 +3,6 @@
 
 import { assert } from "chai";
 
-import * as dotenv from "dotenv";
-dotenv.config();
-
 import {
   AnomalyAlertConfiguration,
   AnomalyDetectionConfiguration,

sdk/metricsadvisor/ai-metrics-advisor/test/public/advisorclient.spec.ts

@@ -3,9 +3,6 @@
 
 import { assert } from "chai";
 
-import * as dotenv from "dotenv";
-dotenv.config();
-
 import {
   MetricAnomalyFeedback,
   MetricChangePointFeedback,