[storage-file-datalake] Allow DataLakePathClient.move() use sas to authenticate source and destination

sdk/storage/storage-file-datalake/src/clients.ts

@@ -86,7 +86,13 @@ import {
 } from "./utils/constants";
 import { DataLakeAclChangeFailedError } from "./utils/DataLakeAclChangeFailedError";
 import { createSpan } from "./utils/tracing";
-import { appendToURLPath, setURLPath } from "./utils/utils.common";
+import {
+  appendToURLPath,
+  encodeURLPathQueries,
+  getURLQueryString,
+  setURLPath,
+  setURLQueries
+} from "./utils/utils.common";
 import { fsCreateReadStream, fsStat } from "./utils/utils.node";
 
 /**
@@ -877,7 +883,8 @@ export class DataLakePathClient extends StorageClient {
    *
    * @see https://docs.microsoft.com/en-us/rest/api/storageservices/datalakestoragegen2/path/create
    *
-   * @param {string} destinationPath Destination directory path like "directory" or file path "directory/file"
+   * @param {string} destinationPath Destination directory path like "directory" or file path "directory/file".
+   *                                 If the destinationPath is authenticated with SAS, add the SAS to the destination path like "directory/file?sasToken".
    * @param {PathMoveOptions} [options] Optional. Options when moving directory or file.
    * @returns {Promise<PathMoveResponse>}
    * @memberof DataLakePathClient
@@ -891,6 +898,7 @@ export class DataLakePathClient extends StorageClient {
    *
    * @param {string} destinationFileSystem Destination file system like "filesystem".
    * @param {string} destinationPath Destination directory path like "directory" or file path "directory/file"
+   *                                 If the destinationPath is authenticated with SAS, add the SAS to the destination path like "directory/file?sasToken".
    * @param {PathMoveOptions} [options] Optional. Options when moving directory or file.
    * @returns {Promise<PathMoveResponse>}
    * @memberof DataLakePathClient
@@ -924,10 +932,28 @@ export class DataLakePathClient extends StorageClient {
 
     // Be aware that decodeURIComponent("%27") = "'"; but encodeURIComponent("'") = "'".
     // But since both ' and %27 work with the service here so we omit replace(/'/g, "%27").
-    const renameSource = `/${this.fileSystemName}/${encodeURIComponent(this.name)}`;
-    const renameDestination = `/${destinationFileSystem}/${destinationPath}`;
+    const sourceSas = getURLQueryString(this.dfsEndpointUrl);
+    const renameSource = !!sourceSas
+      ? encodeURLPathQueries(
+          `/${this.fileSystemName}/${encodeURIComponent(this.name)}?${sourceSas}`
+        )
+      : `/${this.fileSystemName}/${encodeURIComponent(this.name)}`;
+
+    const split: string[] = destinationPath.split("?");
+    let destinationUrl: string;
+    if (split.length === 2) {
+      const renameDestination = `/${destinationFileSystem}/${split[0]}`;
+      destinationUrl = setURLPath(this.dfsEndpointUrl, renameDestination);
+      destinationUrl = setURLQueries(destinationUrl, split[1]);
+    } else {
+      const renameDestination = `/${destinationFileSystem}/${destinationPath}`;
+      destinationUrl = setURLPath(this.dfsEndpointUrl, renameDestination);
+      // If the source is authenticating using SAS while the destination doesn't have a SAS, fallback to use the source's SAS on the destination
+      if (!!sourceSas) {
+        destinationUrl = setURLQueries(destinationUrl, sourceSas);
+      }
+    }
 
-    const destinationUrl = setURLPath(this.dfsEndpointUrl, renameDestination);
     const destPathClient = new DataLakePathClient(destinationUrl, this.pipeline);
 
     try {

sdk/storage/storage-file-datalake/src/utils/utils.common.ts

@@ -372,6 +372,62 @@ export function getURLQueries(url: string): { [key: string]: string } {
   return queries;
 }
 
+/**
+ * Get URL query string.
+ *
+ * @param {string} url
+ */
+export function getURLQueryString(url: string): string | undefined {
+  const urlParsed = URLBuilder.parse(url);
+  return urlParsed.getQuery();
+}
+
+/**
+ * Set URL query string.
+ *
+ * @param {string} url
+ * @param {string} queryString
+ */
+export function setURLQueries(url: string, queryString: string): string {
+  const urlParsed = URLBuilder.parse(url);
+  urlParsed.setQuery(queryString);
+  return urlParsed.toString();
+}
+
+/**
+ * Encode URL path query values from an URL string.
+ *
+ * @example {filesystem}/{file}?{sasToken}
+ *
+ * @export
+ * @param {string} urlPath
+ * @returns {string}
+ */
+export function encodeURLPathQueries(urlPath: string): string {
+  const split = urlPath.split("?");
+  if (split.length === 2) {
+    let queryString = split[1];
+    queryString = queryString.trim();
+
+    let querySubStrings: string[] = queryString.split("&");
+    querySubStrings = querySubStrings.filter((value: string) => {
+      const indexOfEqual = value.indexOf("=");
+      const lastIndexOfEqual = value.lastIndexOf("=");
+      return (
+        indexOfEqual > 0 && indexOfEqual === lastIndexOfEqual && lastIndexOfEqual < value.length - 1
+      );
+    });
+    querySubStrings = querySubStrings.map((value: string) => {
+      const [queryKey, queryValue] = value.split("=");
+      return `${queryKey}=${encodeURIComponent(queryValue)}`;
+    });
+    const encodedQueryString = querySubStrings.join("&");
+    return `${split[0]}?${encodedQueryString}`;
+  } else {
+    return urlPath;
+  }
+}
+
 /**
  * Rounds a date off to seconds.
  *