[dev-tool] Removed repo checkout directory assumption #12681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmtemple
requested review from
mikeharder and
praveenkuttappan
as code owners
willmtemple
added
dev-tool
deyaaeldeen
approved these changes
Nov 24, 2020
|
|
||
| const printModes = ["info", "warn", "error", "success", "debug"] as const; | ||
|
|
||
| export type Fn<T = void> = (...values: any[]) => T; | ||
| export type ModeMap<T> = { [k in typeof printModes[number]]: T }; | ||
|
|
||
| const DEV_TOOL_PATH = __dirname.split("dev-tool")[0]; |
There was a problem hiding this comment.
Won't this fail if cloned path happened to have "dev-tool"?
There was a problem hiding this comment.
Good point. __dirname.split(path.sep + "dev-tool" + path.sep).slice(0, -1).join(path.sep + "dev-tool" + path.sep) is probably more reliable as long as we take care not to have a folder named dev-tool anywhere under the dev-tool folder. The most robust solution is to recursively look for the package.json, but I was trying to avoid doing that in module initialization.
kurtzeborn
added
the
Client
ljian3377
pushed a commit
to ljian3377/azure-sdk-for-js
that referenced
this pull request
Jan 22, 2021
* [dev-tool] Removed repo checkout directory assumption. * Improved the logic even more. Co-authored-by: Will Temple <[email protected]>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Feb 10, 2021
[Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681) * update to new swaggers * fix some validation issues * change ErrorResponse to types.json for test * Add systemData to other entities * Fix encoding json to not use errorResponse test * fix validation error * updating examples with latest fixes * fixing a few validation errors * fix validation errors * Fix validation error. * fix int max len issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12287
("Windows" in the linked issue is a red herring, the same bug would apply to Linux and macOS)
dev-tool had a couple of places where it assumed the repository was cloned into a directory named "azure-sdk-for-js", of course that isn't necessarily true. This fixes that.