Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Small README.md update for sessions #12506

Merged
1 commit merged into from
Nov 12, 2020

Conversation

ellismg
Copy link
Member

@ellismg ellismg commented Nov 12, 2020

It looks like the README.md still had a reference to the
createSessionReciver function which was removed in a previous preview.
I removed the reference to this method as the next two paragraphs
describe the two ways to actually create the session.

It looks like the README.md still had a reference to the
`createSessionReciver` function which was removed in a previous preview.
I removed the reference to this method as the next two paragraphs
describe the two ways to actually create the session.
@ellismg
Copy link
Member Author

ellismg commented Nov 12, 2020

Happy to add explicit links to the documentation for these two functions as part of the preamble of each code example if you think the direct links are helpful.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramya-rao-a
Copy link
Contributor

Happy to add explicit links to the documentation for these two functions as part of the preamble of each code example if you think the direct links are helpful.

The code snippets should be good enough

@ghost
Copy link

ghost commented Nov 12, 2020

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3d7ae46 into Azure:master Nov 12, 2020
@ellismg ellismg deleted the ellismg/service-bus-readme-tweak branch November 12, 2020 03:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants