Switch from Testpipeline variable to parameter #11986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
requested review from
danieljurek,
KarishmaGhiya,
mikeharder,
mitchdenny and
weshaggard
as code owners
ghost
added
the
chidozieononiwu
force-pushed
the
feature/MiscEngCommonUpdates
branch
from
4690bcb to
11923f2
Compare
weshaggard
reviewed
Oct 22, 2020
| @@ -31,7 +31,7 @@ stages: | |||
| - checkout: self | |||
| - task: PowerShell@2 | |||
| displayName: Prep template pipeline for release | |||
| condition: and(succeeded(),eq(variables['TestPipeline'],'true')) | |||
| condition: and(succeeded(),eq('${{ parameters.TestPipeline }}','true')) | |||
There was a problem hiding this comment.
Lets switch to a template condition.
chidozieononiwu
force-pushed
the
feature/MiscEngCommonUpdates
branch
from
11923f2 to
c0700ff
Compare
weshaggard
approved these changes
Oct 22, 2020
chidozieononiwu
force-pushed
the
feature/MiscEngCommonUpdates
branch
from
c0700ff to
1546549
Compare
This was referenced Oct 22, 2020
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Oct 22, 2020
Fixes bug introduced in create-pull-request.yml https://dev.azure.com/azure-sdk/internal/_build/results?buildId=584970&view=logs&j=7864f8e6-ba58-5c87-08d3-fc17566432db&t=41709476-b42b-5552-e853-f2ac4a3ad9de Depends on Azure/azure-sdk-for-net#16145 Azure/azure-sdk-for-js#11986 Azure/azure-sdk-for-java#16657 Azure/azure-sdk-for-python#14686
|
/check-enforcer override |
weshaggard
reviewed
Oct 23, 2020
benbp
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Dec 1, 2020
Fixes bug introduced in create-pull-request.yml https://dev.azure.com/azure-sdk/internal/_build/results?buildId=584970&view=logs&j=7864f8e6-ba58-5c87-08d3-fc17566432db&t=41709476-b42b-5552-e853-f2ac4a3ad9de Depends on Azure/azure-sdk-for-net#16145 Azure/azure-sdk-for-js#11986 Azure/azure-sdk-for-java#16657 Azure/azure-sdk-for-python#14686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent template pipeline run triggered by eng/common changes.
Auto close update version Pull Requests for template pipelines.
Switch from TestPipeline variable to parameter
This includes some of the changes from #11944 as other changes on that PR will take longer to complete.