Update BlockBlobClient.uploadStream to use NodeJS.ReadableStream instead of Readable #11483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-Arrowood
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
ghost
added
Storage
|
Thank you for your contribution Ethan-Arrowood! We will review the pull request and get back to you soon. |
|
In hindsight I didn't anticipate other parts of this were dependent on that type being specifically |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this method using
Readabletype rather thanNodeJS.ReadableStreamtype I cannot pass a standard Node.js readable stream. With this change, users can still passReadabletypes to the method since it implementsNodeJS.ReadableStream.Since this is such a small, non-breaking change I thought it was appropriate to just create the PR directly for going an issue. If this is a problem please let me know and I'd be happy to create a tracking issue as well.