[storage][stg74] share lease

[ljian3377]

No description provided.

[jiacfan]

  assert.fail("acquireLease should fail for an invalid duration: -2");

This doesn't match the current value 20

---

Refers to: sdk/storage/storage-file-share/test/leaseclient.spec.ts:104 in c5d9249. [](commit_id = c5d9249, deletion_comment = False)

[jiacfan]

May worth add more cases to cover newly added functions.

[ljian3377]

Will do in follow-up PR.

[XiaoningLiu]

public getShareLeaseClient(proposeLeaseId?: string) {

Why fileClient can get ShareLeaseClient? It just sounds like we can get containerClient from blobClient.

---

Refers to: sdk/storage/storage-file-share/src/Clients.ts:1340 in c5d9249. [](commit_id = c5d9249, deletion_comment = False)

[XiaoningLiu]

export class ShareLeaseClient {

The naming is confusing if ShareLeaseClient can actually manage lease for share or file.

Ideally we should rename it to LeaseClient, but that will be a breaking change.

How about, we rename it to LeaseClient and expose a alias of "ShareLeaseClient" to be deprecated in next major release.

---

Refers to: sdk/storage/storage-file-share/src/ShareFileClient.ts:5700 in c5d9249. [](commit_id = c5d9249, deletion_comment = False)

[ljian3377]

export class ShareLeaseClient {

The naming is confusing if ShareLeaseClient can actually manage lease for share or file.

Ideally we should rename it to LeaseClient, but that will be a breaking change.

How about, we rename it to LeaseClient and expose a alias of "ShareLeaseClient" to be deprecated in next major release.

Refers to: sdk/storage/storage-file-share/src/ShareFileClient.ts:5700 in c5d9249. [](commit_id = c5d9249, deletion_comment = False)

True. It's poorly named by me when doing lease for file. But we previously name FileClient as ShareFileClient, DirectoryClient as ShareDirectoryClient. And we name it BlobLeaseClient in Blob. So I figure we need some prefix 😢

[ljian3377]

Changes in this PR was already merged to stg74base by #11455.