Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type docs fix #11427

Merged
merged 4 commits into from
Sep 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/servicebus/service-bus/src/log.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { createClientLogger } from "@azure/logger";
/**
* The @azure/logger configuration for this package.
* This will output logs using the `azure:event-hubs` namespace prefix.
* @ignore
* @internal
*/
export const logger = createClientLogger("service-bus");

Expand Down
2 changes: 2 additions & 0 deletions sdk/servicebus/service-bus/src/serviceBusMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,8 @@ export function fromAmqpMessage(
* @export
* @param {AmqpMessage} msg
* @returns {AmqpAnnotatedMessage}
* @internal
* @ignore
*/
export function toAmqpAnnotatedMessage(msg: AmqpMessage): AmqpAnnotatedMessage {
const messageHeader = MessageHeader.fromAmqpMessageHeader(msg);
Expand Down
8 changes: 6 additions & 2 deletions sdk/servicebus/service-bus/src/util/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import { ConnectionContext } from "../connectionContext";
import { AmqpError } from "rhea-promise";

/**
* Error message to use when EntityPath in connection string does not match the
* Error message to use when EntityPath in connection string does not match the
* queue or topic name passed to the methods in the ServiceBusClient that create
* senders and receivers.
*
*
* @internal
* @ignore
*/
Expand Down Expand Up @@ -217,6 +217,10 @@ export function logError(err: Error | AmqpError | undefined, ...args: any[]): vo
logErrorStackTrace(err);
}

/**
* @internal
* @ignore
*/
function isError(err: Error | AmqpError | undefined): err is Error {
return err != null && (err as any).name != null;
}