Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Use the swagger generated from the service 7.2-preview #11370

Merged
merged 7 commits into from
Sep 21, 2020
Merged

[Key Vault] Use the swagger generated from the service 7.2-preview #11370

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f544a5b
swagger reference to 7.2-preview/keys.json
sadasant Sep 21, 2020
81daa47
generated update
sadasant Sep 21, 2020
f97cf14
7.2 on keys
sadasant Sep 21, 2020
1919514
7.2 preview on certs and secrets
sadasant Sep 21, 2020
01d7cd0
generated files for secrets and certs
sadasant Sep 21, 2020
6884258
secrets and certs
sadasant Sep 21, 2020
2448600
sticking the swagger change to a specific commit
sadasant Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/keyvault/keyvault-certificates/src/generated/models/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export interface KeyProperties {
exportable?: boolean;
/**
* The type of key pair to be used for the certificate. Possible values include: 'EC', 'EC-HSM',
* 'RSA', 'RSA-HSM', 'oct'
* 'RSA', 'RSA-HSM', 'oct', 'oct-HSM'
*/
keyType?: JsonWebKeyType;
/**
Expand Down Expand Up @@ -956,11 +956,11 @@ export type DeletionRecoveryLevel = 'Purgeable' | 'Recoverable+Purgeable' | 'Rec

/**
* Defines values for JsonWebKeyType.
* Possible values include: 'EC', 'EC-HSM', 'RSA', 'RSA-HSM', 'oct'
* Possible values include: 'EC', 'EC-HSM', 'RSA', 'RSA-HSM', 'oct', 'oct-HSM'
* @readonly
* @enum {string}
*/
export type JsonWebKeyType = 'EC' | 'EC-HSM' | 'RSA' | 'RSA-HSM' | 'oct';
export type JsonWebKeyType = 'EC' | 'EC-HSM' | 'RSA' | 'RSA-HSM' | 'oct' | 'oct-HSM';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadasant Following up from #11477 (comment), why isnt the above change reflecting in the public API surface?


/**
* Defines values for JsonWebKeyCurveName.
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ azure-arm: false
generate-metadata: false
add-credentials: false
license-header: MICROSOFT_MIT_NO_VERSION
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.1/certificates.json
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/certificates.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this GAs, I recommend using a specific commit. We tend to do this in azure-sdk-for-net (comment based on what the value was before your change).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I will do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using this commit now: f9caf92527ccff06c5b66380e6f2b4f50f5e82b3

output-folder: ../
source-code-folder-path: ./src/generated
```
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export interface KeyProperties {
}

// @public
export type KeyType = "EC" | "EC-HSM" | "RSA" | "RSA-HSM" | "oct";
export type KeyType = "EC" | "EC-HSM" | "RSA" | "RSA-HSM" | "oct" | "oct-HSM";

// @public
export interface KeyVaultKey {
Expand Down
211 changes: 180 additions & 31 deletions sdk/keyvault/keyvault-keys/src/generated/keyVaultClient.ts
View file
Open in desktop

Large diffs are not rendered by default.

Loading