[service-bus] Allowing for a SAS key to be directly specified in a connection string. #10951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpark-msft
requested review from
bterlson,
chradek,
HarshaNalluru,
ramya-rao-a and
xirzec
as code owners
ramya-rao-a
reviewed
Sep 2, 2020
…eySignature as a key in connection strings.
richardpark-msft
force-pushed
the
richardpark-sb-track2-sas-safras-2
branch
from
bd8deac to
1f4b461
Compare
richardpark-msft
changed the title
ramya-rao-a
suggested changes
Sep 2, 2020
ramya-rao-a
approved these changes
Sep 3, 2020
|
Well done team. Great effort! |
Co-authored-by: Ramya Rao <[email protected]>
Co-authored-by: Ramya Rao <[email protected]>
…nt it's contract.
…om/richardpark-msft/azure-sdk-for-js into richardpark-sb-track2-sas-safras-2
|
/azp run js - eventhubs-client - tests |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for connection strings to be passed that contain a Shared Access Signature.
This expands core-amqp so it can parse the connection string into a SharedKeyCredential. There are some square-peg/round-hole issues where, for instance, we expose the SharedKeyName and SharedKey that do not make sense for SAS URIs as they don't contain a re-usable key, etc...
Fixes #10832