[storage][stg73] Changefeed follow-up #10827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljian3377
requested review from
bterlson,
HarshaNalluru,
jeremymeng,
jiacfan,
vinjiang,
XiaoningLiu and
xirzec
as code owners
ghost
added
the
added 11 commits
August 26, 2020 10:25
jeremymeng
reviewed
Aug 27, 2020
jeremymeng
reviewed
Aug 27, 2020
sdk/storage/storage-blob-changefeed/review/storage-blob-changefeed.api.md
Outdated
Show resolved
Hide resolved
jeremymeng
reviewed
Aug 27, 2020
sdk/storage/storage-blob-changefeed/src/BlobChangeFeedClient.ts
Outdated
Show resolved
Hide resolved
jeremymeng
reviewed
Aug 27, 2020
added 2 commits
August 27, 2020 14:27
ljian3377
force-pushed
the
changefeed-followwup
branch
from
618bf9e to
317b9d8
Compare
jiacfan
reviewed
Sep 1, 2020
sdk/storage/storage-blob-changefeed/src/LazyLoadingBlobStream.ts
Outdated
Show resolved
Hide resolved
|
Please add Change log for change feed updates. |
jiacfan
reviewed
Sep 2, 2020
jiacfan
reviewed
Sep 2, 2020
ljian3377
added
the
APIChange
XiaoningLiu
reviewed
Sep 3, 2020
| @@ -0,0 +1,7 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.0.0 (Unreleased) | |||
There was a problem hiding this comment.
storage-internal-avro is not a published package? Since not, we don't need this changelog file.
There was a problem hiding this comment.
I'd like to keep the CHANGELOG.md as it is.
Since it's more like a package that's not published (added it to the rush.json as utility:
Line 490 in c94cc0a
XiaoningLiu
reviewed
Sep 3, 2020
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
There was a problem hiding this comment.
We don't need this license file, since changefeed package already has one in the released package.
There was a problem hiding this comment.
Same as above. Let's keep it as it is.
XiaoningLiu
reviewed
Sep 3, 2020
sdk/storage/storage-blob-changefeed/src/LazyLoadingBlobStream.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-change-feed?tabs=azure-portal#understand-change-feed-organization
Azure/azure-sdk-for-net#13999
Azure/azure-sdk-for-net#13885
Azure/azure-sdk-for-net#14131
#9151
TODOs
hexencoding in the response if exists in the fixture for node recordings #10048 is merged.Most change in storage-internal-avro are already reviewed in this PR: #10062, except for a bug fix in sdk/storage/storage-internal-avro/src/AvroReader.ts.