Standardize prettier configurations across the repo #10416
Conversation
deyaaeldeen
requested review from
xirzec,
willmtemple,
HarshaNalluru and
ramya-rao-a
deyaaeldeen
requested review from
danieljurek,
sophiajt,
KarishmaGhiya,
mikeharder,
mitchdenny,
sadasant,
southpolesteve,
weshaggard and
zfoster
as code owners
deyaaeldeen
requested review from
bterlson,
chradek,
daviwil,
jeremymeng,
jiacfan,
joheredi,
ljian3377,
mahdiva,
richardpark-msft,
sarangan12,
schaabs,
vinjiang and
XiaoningLiu
as code owners
| @@ -47,13 +47,13 @@ | |||
| "build:nodebrowser": "rollup -c 2>&1", | |||
| "build:test": "echo skipped", | |||
| "build": "npm run extract-api && npm run build:es6 && npm run build:nodebrowser", | |||
| "check-format": "prettier --list-different --config ../../.prettierrc.json \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | |||
| "check-format": "prettier --list-different --config ../../../.prettierrc.json \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | |||
There was a problem hiding this comment.
should we add --ignore-path ../../../.prettierignore here too for future-proofing? The npm scripts are also more consistent with other libs.
There was a problem hiding this comment.
I am thinking of ditching those hard coded paths because prettier is already smart enough to find the config files automatically, see here. Is there a specific reason for hardcoding that I am not aware of?
There was a problem hiding this comment.
I am happy as long as they are consistent.
There was a problem hiding this comment.
I commented in another thread, but I agree the hard coded paths should be removed if the commands work correctly without them.
There was a problem hiding this comment.
should we add --ignore-path ../../../.prettierignore here too for future-proofing?
done.
jeremymeng
added
Client
deyaaeldeen
force-pushed
the
prettier-configs
branch
from
29ffc33 to
f88e05f
Compare
No description provided.