Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding samples to the template sdk #10050

Merged
merged 8 commits into from
Jul 17, 2020
Merged

adding samples to the template sdk #10050

merged 8 commits into from
Jul 17, 2020

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Jul 14, 2020 •
edited
Loading

  • added samples
  • updated package.json to include scripts for building and running the samples
  • borrowed the karma and nyc configs from text analytics
  • deleted obselete .vscode dir

Fixes the samples part of #6874.

@deyaaeldeen deyaaeldeen requested a review from willmtemple July 14, 2020 16:15
@deyaaeldeen deyaaeldeen self-assigned this Jul 14, 2020
@ramya-rao-a
Copy link
Contributor

Adding @HarshaNalluru to take a look at the karma changes

@ramya-rao-a
Copy link
Contributor

@deyaaeldeen Looks like the build step is failing, can you take a look?

@deyaaeldeen deyaaeldeen requested a review from xirzec as a code owner July 16, 2020 16:44
@deyaaeldeen
Copy link
Member Author

The current failure is in link verification when it tries to verify links to the new sample source files on github but the PR has not been merged yet.

@HarshaNalluru
Copy link
Member

For the "Verification Links", if the link is not available on the master branch at the time of making the PR, @KarishmaGhiya suggested adding them either in a separate PR or add it to the ignore list and update the list once the PR is merged.

@deyaaeldeen
Copy link
Member Author

@HarshaNalluru I put the links to this branch for now and will rewrite the URLs in a subsequent PR after this one gets merged.

@deyaaeldeen deyaaeldeen merged commit c1d5eca into Azure:master Jul 17, 2020
@deyaaeldeen deyaaeldeen deleted the update-template branch July 17, 2020 19:13
@ramya-rao-a ramya-rao-a mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

@xirzec xirzec xirzec left review comments

@KarishmaGhiya KarishmaGhiya KarishmaGhiya approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@willmtemple willmtemple Awaiting requested review from willmtemple

Assignees

@HarshaNalluru HarshaNalluru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deyaaeldeen @ramya-rao-a @HarshaNalluru @xirzec @KarishmaGhiya