Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time to drop Node.js 8 ? #7022

Closed
HarshaNalluru opened this issue Jan 18, 2020 · 5 comments
Closed

Time to drop Node.js 8 ? #7022

HarshaNalluru opened this issue Jan 18, 2020 · 5 comments
Assignees
@ramya-rao-a
Labels
Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] July

Comments

@HarshaNalluru
Copy link
Member

https://nodejs.org/en/about/releases/
image

Is it time to drop Node.js v8 from our CI, pipelines, readmes, etc?
@HarshaNalluru HarshaNalluru added the Client This issue points to a problem in the data-plane of the library. label Jan 18, 2020
@bterlson
Copy link
Member

I don't want to drop Node 8 unless we can show our users have moved on. I would be surprised of Node 8 going EOL means we don't have to deal with Node 8 deployments. On the other side of the coin, Node 8 isn't super expensive to support -it's not another IE6/IE11 situation.

/cc @southpolesteve

@southpolesteve
Copy link
Contributor

southpolesteve commented Jan 21, 2020 •
edited
Loading

I agree with Brian. The data I have seen suggests we should not drop Node 8.

@bterlson
Copy link
Member

Going to close this for now unless someone wants to make an argument for dropping node 8 support? Otherwise lets keep an eye on our UA strings and remove support when it will have minimal impact.

@ramya-rao-a
Copy link
Contributor

1 year and 5 months later...

We are now 17 months from the time Node.js 8 reached end of life and it is high time to re-open this issue :)

We have looked at data and are confident to want to move towards dropping support for Node.js 8

For more, see our support policy.

Re-opening this issue to track the below work

  • Update readme of all packages to replace "support for Node.js 8 and above" with a generic statement that reflects our above approach
  • Update the engines field in the package.json of all packages to start from version 12
  • Update our test matrix to remove Node.js 8

@ramya-rao-a ramya-rao-a reopened this Jun 9, 2021
@ramya-rao-a ramya-rao-a assigned ramya-rao-a and unassigned bterlson Jun 9, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] July milestone Jun 9, 2021
@jeremymeng jeremymeng mentioned this issue Jun 9, 2021
Merged
@ramya-rao-a ramya-rao-a mentioned this issue Jun 17, 2021
Closed
This was referenced Jun 25, 2021
Merged
Merged
ghost pushed a commit that referenced this issue Jun 25, 2021
@ramya-rao-a
Prepare to move to @types/node v12 (#16012)
82085ff 
As part of #7022, we will be moving the version of `@types/node` from 8 to 12
This PR has the changes required to fix the build errors that occurred when trying out this change
- The [Agent](https://nodejs.org/docs/latest-v12.x/api/http.html#http_class_http_agent) class in Node.js 12 has an extra property `maxTotalSockets`. The docs say there is a default value for this, but it it is still marked as a mandatory property in the types. We use our own interface for this class for the purposes of user providing their own custom agent. Am casting it in this PR to the expected type. If anyone has better ideas here, am all ears :)
- `global.URL` is not a thing as per the types for Node.js 12. We needed this to support Node.js 8
- Fixing the types for `port` in the parsed url

The actual move to v12 for `@types/node` will be done in a separate PR
This was referenced Jun 25, 2021
Merged
Merged
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 28, 2021 •
edited
Loading

Thanks for your patience everyone!

With the below work done, we are closing this issue.

Moving forward we will be following the below until/unless we update the approach based on community feedback.

  • Dropping the Node.js versions from the engines field in the package.json file as soon as they reach end of life. This will result in customers installing the next update of the Azure SDK in older Node.js version to get a warning. Additional, the version of @types/node being used will be updated accordingly
  • Dropping the Node.js versions from our test matrix 6 months after it has reached end of life. This gives our customers 6 months to upgrade.

@ramya-rao-a ramya-rao-a mentioned this issue Jun 28, 2021
Merged
ghost pushed a commit that referenced this issue Jun 29, 2021
@ramya-rao-a
Update contributing guide to reflect Node.js support (#16057)
f854a85 
The watchful eyes of @vishnureddy17 found that we still have reference to Node.js 8 in our Contributing Guide!!

This PR fixes that.

Related to #7022
@ramya-rao-a ramya-rao-a mentioned this issue Oct 27, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
4 participants
@bterlson @southpolesteve @HarshaNalluru @ramya-rao-a