Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items.query<T> has mandatory FeedOptions #6277

Closed
1 of 5 tasks
abouroubi opened this issue Nov 20, 2019 · 4 comments
Closed
1 of 5 tasks

items.query<T> has mandatory FeedOptions #6277

abouroubi opened this issue Nov 20, 2019 · 4 comments
Labels
Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@abouroubi
Copy link
Contributor

  • Package Name: @azure/cosmos
  • Package Version: v3.4.2
  • Operating system: Linux
  • [X ] nodejs
    • version: 10.4.1
  • browser
    • name/version:
  • typescript
    • version: 3.6.3
  • Is the bug related to documentation in

Describe the bug
The doc states that the container.items.query<T>()method has 2 parameters SqlQuerySpec and FeedOptions, the second one is supposed to be optional, but the Typescript definition file states that its mandatory.

To Reproduce
Steps to reproduce the behavior:
1.

Expected behavior
The second parameter FeedOptions should be optional

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@maggiepint maggiepint added Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 21, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar @srinathnarayanan @southpolesteve @shurd

1 similar comment
@ghost
Copy link

ghost commented Nov 21, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar @srinathnarayanan @southpolesteve @shurd

southpolesteve added a commit to southpolesteve/azure-sdk-for-js that referenced this issue Nov 21, 2019
@southpolesteve
Copy link
Contributor

Thanks, @abouroubi. I have already addressed in #6258. We should have a release out in the next few days.

@ghost
Copy link

ghost commented Nov 21, 2019

Thanks for working with Microsoft on GitHub! Tell us how you feel about your experience using the reactions on this comment.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants