-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog Verification CI failed for First GA packages #30156
Comments
The message told you the error:
I prefer to change to something like below:
For GA:
|
Normally feature added means minor change, but GA/preview track2 maybe Modular when MPG is ready is not. |
Seems like enforcement was recently changed to block on this: Azure/azure-sdk-tools#8463 "Features Added" is probably the most correct thing to use, and appears to be what others have used for the initial release: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/openai/Azure.AI.OpenAI/CHANGELOG.md#100-beta1-2023-02-06 Perhaps we could make the check smarter about not enforcing recommended sections on the first release though? @weshaggard |
The guidelines have always listed having a required section heading however we recently discovered a bug which didn't correctly fail the validation step, which has been fixed. I don't think we need to special case new releases we should use "Features Added" for those cases. |
FYI, current state here: Azure/azure-sdk-tools#8487 |
We have two first GA release this week:
#30012
#30154
but both of them get failed on Changelog Verification check in pipeline with the error message
Usually, if a package is going to be first GA, the changelog will be
which doesn't have any code details.
not sure whether a first beta package will trigger this error too.
cc @qiaozha @MaryGao
The text was updated successfully, but these errors were encountered: