Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Evaluate expires_on field in AzureCliCredential #27648

Closed
scottaddie opened this issue Nov 3, 2023 · 5 comments · Fixed by #28333
Closed

[Identity] Evaluate expires_on field in AzureCliCredential #27648

scottaddie opened this issue Nov 3, 2023 · 5 comments · Fixed by #28333
Assignees
@maorleger
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
2024-02

Comments

@scottaddie
Copy link
Member

As of Azure CLI v2.54.0, the az account get-access-token command returns a new expires_on field containing a POSIX timestamp. This behavior is a departure from previous versions, in which the local datetime was returned in an expiresOn field. Update AzureCliCredential to also consider the new expires_on field.

Related links:
@scottaddie scottaddie added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Nov 3, 2023
@scottaddie scottaddie added this to the 2024-02 milestone Nov 3, 2023
@scottaddie scottaddie moved this from Untriaged to Blocked in Azure Identity SDK Improvements Nov 3, 2023
@scottaddie
Copy link
Member Author

Marking as blocked until the az cli release ships.

@KarishmaGhiya
Copy link
Member

Assigning Matt, since I will be leaving for vacation soon.

@KarishmaGhiya KarishmaGhiya removed their assignment Nov 7, 2023
@scottaddie scottaddie moved this from Blocked to Not Started in Azure Identity SDK Improvements Nov 14, 2023
@antkmsft
Copy link
Member

Marking as blocked until the az cli release ships.

Az CLI v.2.54.0 has shipped, I was able to obtain it via Winget.

@ahsonkhan
Copy link
Contributor

Office hour discussion conclusion across languages:
Azure/azure-sdk-for-cpp#5116 (comment)

@joshfree joshfree modified the milestones: 2024-02, 2024-03 Jan 8, 2024
@ahsonkhan
Copy link
Contributor

This change is addressed in C++, and similar changes can be made in other languages.

The gist is:

  • We want to parse and use the new expires_on field if it exists, as is, as a Posix time (seconds since UTC). In this case, we don't use the existing field at all.
  • If that new field doesn't exist, use the existing expiresOn field as a fallback, parsed as local time.
    • The existing expiresOn field deviates a bit from RFC 3339 and doesn't have the timezone info in the string to indicate the local time offset (no Z or +XX:XX), so we assume it is considered local time.

Test example:
https://github.com/Azure/azure-sdk-for-cpp/blob/cb73bbd62cb825171cd598bfc1936aea40ebbaa0/sdk/identity/azure-identity/test/ut/azure_cli_credential_test.cpp#L229-L277

PRs in C++ for inspiration, if relevant:
Azure/azure-sdk-for-cpp#5179
Azure/azure-sdk-for-cpp#5180

@joshfree joshfree assigned maorleger and unassigned mpodwysocki Jan 22, 2024
@maorleger maorleger mentioned this issue Jan 22, 2024
Merged
3 tasks
maorleger added a commit that referenced this issue Jan 24, 2024
@maorleger
[identity] Use expires_on if az cli credential provides it (#28333)
e7afb55 
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

Resolves #27648

### Describe the problem that is addressed by this PR

In version 2.54.0 the Azure CLI started including an `expires_on` field
containing a POSIX timestamp in seconds in addition to the existing
`expiresOn` field denoting the expiry in RFC3339 format.

We want to migrate to `expires_on` when the underlying az cli supports
it and fallback to the existing `expiresOn` otherwise.


### Provide a list of related PRs _(if any)_

Azure/azure-sdk-for-net#41366
Azure/azure-sdk-for-cpp#5075
@github-project-automation github-project-automation bot moved this from Not Started to Done in Azure Identity SDK Improvements Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2024-02
Development

Successfully merging a pull request may close this issue.

[identity] Use expires_on if az cli credential provides it maorleger/azure-sdk-for-js
7 participants
@maorleger @joshfree @ahsonkhan @KarishmaGhiya @scottaddie @mpodwysocki @antkmsft