Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain #25717

Closed
xiangyan99 opened this issue May 1, 2023 · 4 comments · Fixed by #26684
Closed

DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain #25717

xiangyan99 opened this issue May 1, 2023 · 4 comments · Fixed by #26684
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
2023-06

Comments

@xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 1, 2023
This was referenced May 1, 2023
Closed
Closed
Closed
@xiangyan99
Copy link
Member Author

Azure/azure-sdk-for-net#35919
Azure/azure-sdk-for-java#34733
#25717
Azure/azure-sdk-for-python#30167

@joshfree joshfree added this to the 2023-06 milestone May 1, 2023
@KarishmaGhiya
Copy link
Member

JS doesn't have a SharedToken Credential, so we could close this issue.

@xiangyan99 xiangyan99 changed the title Revisit DAC: should we not stop on shared token cache credential if we find an expired one DAC: do not stop trying with dev credentials until obtaining a valid token or completing the chain May 22, 2023
@KarishmaGhiya KarishmaGhiya reopened this May 31, 2023
@KarishmaGhiya
Copy link
Member

Need to check for other dev time credentials - even if there are hard exceptions, keep going in the DAC chain, don't stop

@xiangyan99
Copy link
Member Author

The Python PR: Azure/azure-sdk-for-python#30441

@KarishmaGhiya KarishmaGhiya mentioned this issue Aug 1, 2023
Merged
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2023-06
3 participants
@joshfree @KarishmaGhiya @xiangyan99