[Service Bus] Long is undefined after updating the long npm package from 4.0 to 5.2.

[abouroubi]

• Package Name: @azure/service-bus
• Package Version: 7.7.3
• Operating system: Linux/MacOS
• nodejs
  • version: 18.12.1
• browser
  • name/version:
• typescript
  • version: 4.8.4
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug
There is an issue with the latest version of long, and it made the service-bus SDK unusable...
dcodeIO/long.js#109

Following the discussion started in #21208 (comment)

To Reproduce
Steps to reproduce the behavior:

1. import Long from 'long' package
2. Use Long.fromString() function to convert a string message id to long to be able to use it with the Service Bus SDK.
3. The app will crash with this error: TypeError: Cannot read properties of undefined (reading 'fromString')

Expected behavior
The conversion of string to Long to happen without issues.

Additional context
Here is the code used:

import {
  ProcessErrorArgs,
  ServiceBusClient,
  ServiceBusMessage,
  ServiceBusReceivedMessage,
  ServiceBusReceiver,
  ServiceBusSender,
} from '@azure/service-bus';
import Long from 'long';


export class QueueService {

  private sbClient: ServiceBusClient;
  private sender: ServiceBusSender;
  private receiver: ServiceBusReceiver;

  constructor() {
    this.sbClient = new ServiceBusClient("[ConnectionString]");
    this.sender = this.sbClient.createSender("[QueueName]");
    this.receiver = this.sbClient.createReceiver("[QueueName]");
  }

  async sendMessage(body: any, scheduledEnqueueTimeUtc: Date): Promise<string> {
    const message: ServiceBusMessage = {
      body: body,
    };
    const results = await this.sender.scheduleMessages(message, scheduledEnqueueTimeUtc);

    return results[0].toString();
  }

  async cancelMessage(messageId: string) {
    this.sender.cancelScheduledMessages(Long.fromString(messageId));
  }

  async receiveMessages(
    processMessage: (message: { id: string; content: string }) => Promise<void>,
    processError: () => Promise<void>,
  ) {
    const process = async (brokeredMessage: ServiceBusReceivedMessage) => {
      await processMessage(brokeredMessage.body);
      await this.receiver.completeMessage(brokeredMessage);
    };
    const error = async (args: ProcessErrorArgs) => {
      await processError();
    };

    this.receiver.subscribe(
      {
        processMessage: process,
        processError: error,
      },
      {
        autoCompleteMessages: false,
      },
    );
  }
}

[jeremymeng]

@abouroubi Thanks for sharing the repo code! I gave it a try with slight modification in a standard TypeScript project and it worked as expected for me. I don't see any errors. Here's the list of my commits: https://github.com/jeremymeng/js-24168/commits/master

Could you please take a look, and let me know what I might be missing, comparing to your environment?

[ghost]

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!