Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Load Testing Readme Issue #24041

Closed
zzhxiaofeng opened this issue Nov 29, 2022 · 4 comments
Closed

Azure Load Testing Readme Issue #24041

zzhxiaofeng opened this issue Nov 29, 2022 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Docs Load Test Service RestLevelClient test-manual-pass

Comments

@zzhxiaofeng
Copy link
Contributor

zzhxiaofeng commented Nov 29, 2022

Section link
Screenshot 2022-11-29 154344
Reason:
client is not defined.

Suggestion:
Update to Client. Capitalize the first letter.

@joheredi, @dw511214992 for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Docs:0.087502696,Storage:0.08255051,Azure.Core:0.06489762'

@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass Load Testing labels Nov 29, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2022
@xirzec xirzec removed the needs-team-triage Workflow: This issue needs the team to triage. label Nov 29, 2022
@qiaozha
Copy link
Member

qiaozha commented Feb 8, 2023

The code example should have been updated. @zzhxiaofeng Could you help verify and let us know if it looks good ?

@zzhxiaofeng
Copy link
Contributor Author

@qiaozha This issue has been fixed, but I find some new issues occured in the latest readme.
1.
Section link1, link2, link3
MicrosoftTeams-image (6)
MicrosoftTeams-image (8)
MicrosoftTeams-image (9)
MicrosoftTeams-image (10)
Reason:
1.Cannot find AzureLoadTesting.
2.Cannot find Endpoint.
3.Cannot find isUnexpected.
4.Property 'timeout' does not exist on type '{ new (): AbortController; prototype: AbortController; }'.
5.Cannot find fileUploadPoller.
6.Cannot find testRunId.

Suggestion:
1.Import  AzureLoadTesting from @azure-rest/load-testing.
2.Update Endpoint to "<Endpoint>".
3.Import  isUnexpected from @azure-rest/load-testing.
4.Import { AbortController } from "@azure/abort-controller".
5.Update fileUploadPoller to fileValidatePoller.
6.Update testRunId to TEST_RUN_ID.

@v-xuto
Copy link
Member

v-xuto commented Mar 1, 2023

This issue has been resolved. We will close it.

@v-xuto v-xuto closed this as completed Mar 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Docs Load Test Service RestLevelClient test-manual-pass
Projects
None yet
Development

No branches or pull requests

7 participants