Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Bus: Add CORS support for topic creation in the browser #23325

Closed
federicoder opened this issue Sep 27, 2022 · 6 comments
Closed

Service Bus: Add CORS support for topic creation in the browser #23325

federicoder opened this issue Sep 27, 2022 · 6 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Bus

Comments

@federicoder
Copy link

  • Package Name:
  • "@azure/identity": "^3.0.0",
    "@azure/service-bus": "^7.7.1",
  • Operating system:
  • ArchLinux
  • [ v 18.7.0] nodejs

Describe the bug
Hi all, i try to create a topic with javascript sdk for azure service bus from stencilJS library, but i receive always this error:
(I receive the same error also when i import the webcomponent into angular, so i think it's not related to stencilJS the error):

image

This is the simple code i implemented following the official samples:

   this.sbAdministrationClient = new ServiceBusAdministrationClient(this.connectionString)
    this.checkOrCreateTopic();
async checkOrCreateTopic(){
     await this.sbAdministrationClient.createTopic("local-webcomponent")
  }

I can't create topics and queues from sdk, but when if i create topics by portal.azure.com, and i use sdk to create subscriptions and i can do it. Can someone help me please?

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 27, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Service Bus labels Sep 27, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 27, 2022
@xirzec xirzec removed the needs-team-triage Workflow: This issue needs the team to triage. label Sep 27, 2022
@jeremymeng
Copy link
Member

@federicoder thank you very much for reporting the issue! I tried to repo locally in a vanilla HTML + bundled JavaScript code, but this similar code below worked fine for me (after disabling browser security for CORS). I wonder whether something went wrong when integrating with other framework. Is it possible for you to share a simplified project that demonstrates this issue?

async function checkOrCreateTopic(){
  const sbAdministrationClient = new ServiceBusAdministrationClient(connectionString);
  const response = await sbAdministrationClient.createTopic(topicName);
  console.log("##### topic created successfully");
  console.log(response);
}

image

@jeremymeng jeremymeng added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Sep 27, 2022
@federicoder
Copy link
Author

hi @jeremymeng , thank you for reply, I solved by disabling browser security for CORS.
I have question: Is there a way to create a topic, without disabling cors security for broswer?

@jeremymeng jeremymeng removed the needs-author-feedback Workflow: More information is needed from author to address the issue. label Sep 28, 2022
@jeremymeng
Copy link
Member

@federicoder This is actually a known issue due to Service Bus backend service. I am going to ask the service team about the status again but currently I am not aware of a way other than disabling browser CORS security.

@federicoder
Copy link
Author

okay thank you very much @jeremymeng , can we keep in touch if you will know something about this thing in future?

@jeremymeng
Copy link
Member

@federicoder yes, we will keep this issue open and I will update here.

@xirzec xirzec added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 30, 2023
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Mar 30, 2023
@xirzec xirzec changed the title Error when i try to create a topic with sdk Service Bus: Add CORS support for topic creation in the browser Mar 30, 2023
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 25, 2023
Release of microsoft.network api version: 2022 11 01 (Azure#23652)

* Adds base for updating Microsoft.Network from version stable/2022-09-01 to version 2022-11-01

* Updates readme

* Updates API version in new specs and examples

* remove loadDistributionPolicy from appgw PUT request body example (Azure#23144)

* remove loadDistributionPolicy from appgw PUT request body example

* remove loadDistributionPolicy from appgw PUT request body example2

* remove loadDistributionPolicy from appgw PUT request body example

* remove duplicates

* add private link configuration to see if it will fix validation error

* remove privateLinkConfig related

* revert changes to see if still get validation error

* update back to original changes

* add response resource id to fix modelValidation error

* add connection resource

* Selector in Exclusions should not be required as Operator EqualsAny does not need a Selector (Azure#23184)

* Application Gateway WAF Rate Limit feature swagger changes (Azure#23021)

* Application Gateway WAF Rate Limit feature swagger changes

* Fixing lint errors

* Updated rate limit feature examples

* Fix for applicationGatewayIpConfigurations property and make the priority parameter as required for NSG (Azure#23210)

* Fix for applicationGatewayIpConfigurations property

This swagger definition is defining property applicationGatewayIpConfigurations,

```
"applicationGatewayIpConfigurations": {
          "type": "array",
          "items": {
            "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration"
          },
          "description": "Application gateway IP configurations of virtual network resource."
        }
```
but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case.
```
{
  "name": "subnet-agw",
  "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw",
  "properties": {
      "applicationGatewayIPConfigurations": [
          {
              "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig"
          }
      ]
  },
  "type": "Microsoft.Network/virtualNetworks/subnets"
}
```

* Making priority property required

[This is the API invoked](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0).

For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below.

Request Body:

```
{
  "properties": {
    "securityRules": [
      {
        "name": "rule1",
        "properties": {
          "protocol": "*",
          "sourceAddressPrefix": "*",
          "destinationAddressPrefix": "*",
          "access": "Allow",
          "destinationPortRange": "80",
          "sourcePortRange": "*",
          "direction": "Inbound"
        }
      }
    ]
  },
  "location": "eastus"
}
```
Response received:

```
{
  "error": {
    "code": "SecurityRuleInvalidPriority",
    "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.",
    "details": []
  }
}
```
This PR will make the priority parameter as required.

* Update NetworkSecurityGroupDelete.json

* Update NetworkSecurityGroupRuleDelete.json

* Update NetworkSecurityGroupDelete.json

* Undo previous change of making fields optional within Exclusion (Azure#23325)

* Nivishenker/http headers to insert (Azure#23295)

* new app rule property - http header to insert

* prettier

* add to 22-11-01

* removed changes from 22-09-01

* fixed example

* delete RCG example

* fix delete examples

* added a Location header

* prettier fix

* Application Gateway WAF Log scrubbing swagger changes (Azure#23022)

* Log scrubbing API changes

* Update examples

* Addressing comments

* Fix

* Update property in load balancer for Connection Draining Phase 1 (Azure#23082)

* Update property in load balancer for Coneection Draining Phase 1

* Fix model validation

* Azure Firewall Packet Capture API. Cancelled PR from 2022-09-01 and created for 2022-11-01 (Azure#23114)

* moving packet-capture api to 2022-11-01 release from 2022-09-01

* fixing the LRO response header error for model validation

* Changes for Additional nic and corrections (Azure#23522)

* Changes for Additional nic and corrections

* Fixes for tool reported issues

* Fix for SpellCheck, ModelValidation

* Defining Location in NetworkVirtualApplianceDelete for async

* Minor fix

* Minor fix

* Minor fix

* PrettierCheck fixed

* Fixing VirtualApplianceAdditionalNicProperties

* ModelValidation fixed

* Correcting the location header string

* Correcting location header

* Prettied Check Fix

* Fix

* Fix

* Add inspection limit changes (Azure#23536)

* Fixed headers for examples (Azure#23554)

* Fix response of API: List of advertised/learned BGP routes (Azure#23555)

* fix response type

* fix format

* fix example, add x-ms-identifiers

* AuxiliarySku on Nic (Azure#23552)

* Adding auxiliary sku property on nic

* Adding AcceleratedConnections to AuxMode

* modifying the auxSku values

* Removing accidental change

---------

Co-authored-by: Prachi Pravin Bhavsar <[email protected]>

* migrated latest pr from incorrect branch (Azure#23589)

* Changes for NVA connection (Azure#23173)

* Changes for NVA connection

* Changes to address validation failures

* Fix some ModelValidation errors

* Fix some ModelValidation errors

* Fix some ModelValidation errors

* Fix some ModelValidation errors

* Fix some ModelValidation errors

* Addressing some review comments

* Addressing some review comments

* Addressing some review comments

* Addressing some review comments

* Addressing some review comments

* Fix camel case for property name

* Fixing resourceUri to Camel case in example files

* Fix SDK duplication error

* Fix one LintDiff error

* try fix lintdiff errors

* fix lro erro in lintdiff

* fix model validation error

* Bastion S360 for 2022-11 version (Azure#23595)

* Release microsoft.network 2022 11 01 (Azure#23564)

* Application Gateway WAF Rate Limit feature swagger changes

* Fixing lint errors

* Updated rate limit feature examples

* rateLimitDuration and rateLimitThreshold are not mandatory. There are only mandatory if ruleType is RateLimitRule. This validation will be done in NRP.

* Fix attempt 2. Removed minimum constraint from rateLimitThreshold. Validation will be done in NRP

* Remove the minimum number for the option field requestBodyInspectLimitInKB (Azure#23663)

* Remove minimum value for optional field requestBodyInspectLimitInKB

* Remove exlcusiveMinimum

---------

Co-authored-by: htippanaboya <[email protected]>
Co-authored-by: tracyMicro <[email protected]>
Co-authored-by: tejasshah7 <[email protected]>
Co-authored-by: sraghavan-msft <[email protected]>
Co-authored-by: navba-MSFT <[email protected]>
Co-authored-by: NiviShenker <[email protected]>
Co-authored-by: Sindhu Aluguvelli <[email protected]>
Co-authored-by: phrazfipho <[email protected]>
Co-authored-by: nikhilpadhye1 <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: karanbazaz <[email protected]>
Co-authored-by: yeliMSFT <[email protected]>
Co-authored-by: pracsb <[email protected]>
Co-authored-by: Prachi Pravin Bhavsar <[email protected]>
Co-authored-by: nanditaashok-ms <[email protected]>
Co-authored-by: anvrao1 <[email protected]>
Co-authored-by: baoqihuang0326 <[email protected]>
Copy link

Hi @federicoder, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Bus
Projects
Status: Done
Development

No branches or pull requests

4 participants