Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set x-ms-app HTTP request header in Monitor Query library #21196

Closed
scottaddie opened this issue Apr 5, 2022 · 1 comment
Closed

Set x-ms-app HTTP request header in Monitor Query library #21196

scottaddie opened this issue Apr 5, 2022 · 1 comment
Assignees
@KarishmaGhiya
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Milestone
2022-08

Comments

@scottaddie
Copy link
Member

scottaddie commented Apr 5, 2022 •
edited
Loading

Library name

@azure/monitor-query

Please describe the feature.

The Azure Monitor Log Analytics service team stores the caller information for their REST APIs. To support tracking HTTP requests from the Azure Monitor Query library, send an x-ms-app request header. The header's value should be set to AzureMonitorQuerySDK. The metrics team uses the user agent to identify the caller. Send this header ONLY for logs queries.
@scottaddie scottaddie added Client This issue points to a problem in the data-plane of the library. Monitor - Query labels Apr 5, 2022
@KarishmaGhiya KarishmaGhiya added this to the [2022] May milestone Apr 5, 2022
@xirzec xirzec modified the milestones: [2022] May, [2022] June May 17, 2022
@srnagar srnagar removed this from the Backlog milestone Jun 6, 2022
@scottaddie scottaddie added this to the [2022] August milestone Jun 6, 2022
@scottaddie scottaddie added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jun 15, 2022
@srnagar srnagar mentioned this issue Jul 22, 2022
Closed
@scottaddie
Copy link
Member Author

After reviewing with the arch board, a decision was made to not make this change. As a workaround, the Draft service team can run a contains operation on the user agent string to identify the caller. This workaround has been communicated to Dan Hadari.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Oct 31, 2022
CodeGen from PR 21196 in Azure/azure-rest-api-specs
32c641e 
[Hub Generated] Review request for Microsoft.Peering to add version stable/2022-10-01 (Azure#21196)

* Adds base for updating Microsoft.Peering from version stable/2022-06-01 to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* update peering api version

* update peering api version

* fixing resource inheritance

* making readme.md consistent with previous versions

* lint diff fix

* fixing serialization for examples
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
2022-08
Development

No branches or pull requests
4 participants
@xirzec @KarishmaGhiya @scottaddie @srnagar