Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema Registry - Avro] With messaging clients Event Hub Serialize with Schema failing in nightly runs #20839

Closed
v-jiaodi opened this issue Mar 15, 2022 · 0 comments · Fixed by #20902
Closed

[Schema Registry - Avro] With messaging clients Event Hub Serialize with Schema failing in nightly runs #20839

v-jiaodi opened this issue Mar 15, 2022 · 0 comments · Fixed by #20902
Assignees
@deyaaeldeen
Labels
Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Schema Registry test-reliability Issue that causes tests to be unreliable

Comments

@v-jiaodi
Copy link
Member

Schema Registry - Avro nightly test runs are failing with:

Stack trace:
RestError: SubCode=40300, Cannot create schema interop.avro.ReaderSchema in group azsdk_js_test_group because no more than 25 schemas is allowed. Currently there are 25 schemas for the group. TrackingId:e7fe29e8-d5cb-4273-8c90-49af41756fe7_D1, SystemTracker:NoSystemTracker, Timestamp:2022-03-12T05:02:31
at handleErrorResponse$2 (core/core-client/src/deserializationPolicy.ts:261:4)
at deserializeResponseBody$2 (core/core-client/src/deserializationPolicy.ts:172:21)

For more details check here:
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 15, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Schema Registry labels Mar 15, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 15, 2022
@v-xuto v-xuto added the test-reliability Issue that causes tests to be unreliable label Mar 15, 2022
@deyaaeldeen deyaaeldeen mentioned this issue Mar 17, 2022
Merged
3 tasks
deyaaeldeen added a commit that referenced this issue Mar 17, 2022
@deyaaeldeen
[Schema Registry Avro] Add an error scenario (#20902)
1daba67 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes #20839

### Describe the problem that is addressed by this PR
One of the tests is currently failing because the CI resource only allows up to 25 unique schemas per a schema group but that number is exhausted by another test that checks whether the growth of the serializer's internal cache is bounded. This PR reduces the number of schemas registered in the latter so there is enough room for subsequent tests to register their own schemas.

Furthermore, an additional test is added that checks an error case when deserializing with incompatible schema.

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A

### Are there test cases added in this PR? _(If not, why?)_
Yes. Also see a successful nightly run in https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1439397&view=results

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@deyaaeldeen @WeiJun428
[Schema Registry Avro] Add an error scenario (Azure#20902)
e2bffee 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes Azure#20839

### Describe the problem that is addressed by this PR
One of the tests is currently failing because the CI resource only allows up to 25 unique schemas per a schema group but that number is exhausted by another test that checks whether the growth of the serializer's internal cache is bounded. This PR reduces the number of schemas registered in the latter so there is enough room for subsequent tests to register their own schemas.

Furthermore, an additional test is added that checks an error case when deserializing with incompatible schema.

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A

### Are there test cases added in this PR? _(If not, why?)_
Yes. Also see a successful nightly run in https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1439397&view=results

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@deyaaeldeen @WeiJun428
[Schema Registry Avro] Add an error scenario (Azure#20902)
b7be4d6 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes Azure#20839

### Describe the problem that is addressed by this PR
One of the tests is currently failing because the CI resource only allows up to 25 unique schemas per a schema group but that number is exhausted by another test that checks whether the growth of the serializer's internal cache is bounded. This PR reduces the number of schemas registered in the latter so there is enough room for subsequent tests to register their own schemas.

Furthermore, an additional test is added that checks an error case when deserializing with incompatible schema.

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A

### Are there test cases added in this PR? _(If not, why?)_
Yes. Also see a successful nightly run in https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1439397&view=results

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Feb 3, 2023
@riteshchitlangia
CodeGen from PR 20839 in Azure/azure-rest-api-specs
79cb20a 
[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2022-11-01 (Azure#20839)

* Adds base for updating Microsoft.KeyVault from version stable/2022-07-01 to version 2022-11-01

* Updates readme

* Updates API version in new specs and examples

* Adding specification for data plane Key operations through Managed HSM control plane (via ARM)

* undo of change done to address R3006

* Updating duplicate tags and operation id

* Addressing PR comments from ARM review

* PR Feedback : update string.

* Fixing lint errors and some PR feedback

* fixing prettier checks

* fixing validation errors from lint diff

* Making ManagedHsmKey as proxy resource by removing 'Tags' and 'Location' properties from it.

* Adding Tags

* removing additional property 'Location'

* Removed unreferenced parameter definitions.

* Updating examples to have default value for enablePurgeProtection as false as per PR feedback.

* Merging changes made to version 2022-07-01 in PR Azure/azure-rest-api-specs#21671
This added securitydomainproperties and fixed a s360 item.

* Fixing validation errors from PR

* Adding suppresion based on new rules described here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/828/How-to-suppress-validation-rules and removing swagger changes for headers.

* Pulled a breaking change from 2022-07-01 api-version and Updated where clause path

---------

Co-authored-by: FAREAST\riteshc <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Schema Registry test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Schema Registry Avro] Add an error scenario deyaaeldeen/azure-sdk-for-js
4 participants
@deyaaeldeen @azure-sdk @v-xuto @v-jiaodi