-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracing] - Upgrade a few packages to core-tracing preview.14 for dogfooding #20213
Closed
3 tasks done
Labels
Milestone
Comments
ghost
added
the
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
label
Feb 4, 2022
azure-sdk
added
Azure.Core
Client
This issue points to a problem in the data-plane of the library.
needs-team-triage
Workflow: This issue needs the team to triage.
labels
Feb 4, 2022
ghost
removed
the
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
label
Feb 4, 2022
maorleger
removed
the
needs-team-triage
Workflow: This issue needs the team to triage.
label
Feb 4, 2022
@KarishmaGhiya I assigned both of us, let's decide how we divide and conquer this effort. I believe eventhubs will be the more challenging one so I am happy to take that one and core-rest-pipeline if you want to take data-tables |
4 tasks
maorleger
added a commit
that referenced
this issue
Feb 15, 2022
### Packages impacted by this PR @Azure/event-hubs @azure/test-utils ### Issues associated with this PR #20213 ### Describe the problem that is addressed by this PR Now that @azure/[email protected] is out, and hopefully the last version before GA, we need to upgrade a few packages in order to dogfood both the upgrade experience and the usage of these packages with the new [instrumentation package](https://www.npmjs.com/package/@azure/opentelemetry-instrumentation-azure-sdk). My goal was to upgrade one AMQP package and a few HTTP packages in addition to core-rest-pipeline to collect feedback. Upgrading EventHubs now allows us to start using the new APIs in a client package. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Haven't decided if this should be merged _or_ if we should just publish to NPM under a custom tag in order to allow customers to dogfood. I know there's an internal IoT Hub engineer that is interested in helping out so we just need something for them to try. Right now though I am leaning towards merging this in. I also decided to dump all the `parentSpan` legacy stuff - there really isn't a need to maintain tracing backwards compat with an option that has not been used in over 6 months.
3 tasks
maorleger
added a commit
that referenced
this issue
Feb 17, 2022
### Packages impacted by this PR @azure/data-tables ### Issues associated with this PR - #20213 - #5607 ### Describe the problem that is addressed by this PR Now that @azure/[email protected] is out, and hopefully the last version before GA, we need to upgrade a few packages in order to dogfood both the upgrade experience and the usage of these packages with the new instrumentation package. My goal was to upgrade one AMQP package and a few HTTP packages in addition to core-rest-pipeline to collect feedback. Upgrading Data Tables now allows us to start using the new APIs in a client package. ### Provide a list of related PRs _(if any)_ - #20240
Closing as upgrades are done and am awaitng feedback from dogfooders |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this issue
Aug 12, 2022
Update readme.python.md (Azure#20213)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
While we don't have data on usage yet, we will in a month, I believe the following packages would be good proxies for validating our changes:
These will be a good start
The text was updated successfully, but these errors were encountered: