[Schema Registry Avro] Consider wrapping avsc errors #20072
Comments
This was referenced Jan 26, 2022
5 tasks
3 tasks
deyaaeldeen
added a commit
that referenced
this issue
Mar 25, 2022
### Packages impacted by this PR @azure/schema-registry-avro ### Issues associated with this PR Fixes #20072 ### Describe the problem that is addressed by this PR @azure/schema-registry-avro depends on avsc, a third party package for Avro encoding, and it throws exceptions in certain cases. If in the future we decide to switch away from avsc to some other library, @azure/schema-registry-avro will be throwing new and different exceptions. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? - Wrapping avsc exceptions in @azure/schema-registry-avro exceptions so that the customer experience stays consistent regardless of which Avro library to use. One question remain: should one exception suffice or should fine-grained exceptions provided? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this issue
Aug 3, 2022
Add Grafana integrations (Azure#20072)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@azure/schema-registry-avrodepends onavsc, a third party package for Avro encoding, and it throws exceptions in certain cases. If in the future we decide to switch away fromavscto some other library,@azure/schema-registry-avrowill be throwing new and different exceptions.To get around this issue, consider wrapping
avscexceptions in@azure/schema-registry-avroexceptions so that the customer experience stays consistent regardless of which Avro library to use.The text was updated successfully, but these errors were encountered: