Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency package jwt-decode has a new version available #19224

Closed
azure-sdk opened this issue Dec 10, 2021 · 5 comments
Closed

Dependency package jwt-decode has a new version available #19224

azure-sdk opened this issue Dec 10, 2021 · 5 comments
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@azure-sdk
Copy link
Collaborator

We have identified a dependency on jwt-decode (2.2.0). A new version (3.1.2) is available now.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
This was referenced Dec 13, 2021
Closed
Closed
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Dec 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Dec 15, 2021
Closed
@ramya-rao-a
Copy link
Contributor

This task should be picked up along with #19162

@ramya-rao-a ramya-rao-a mentioned this issue Dec 15, 2021
Closed
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Dec 15, 2021
@ramya-rao-a
Copy link
Contributor

@DominikMe The dependency on jwt-deocde was added in this very first mega PR for ACS packages in #11385. Do you recall the reason you went with v2 and not v3 of jwt-deocde?

@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Jan 18, 2022
@ramya-rao-a
Copy link
Contributor

Code pointers for anyone wanting to contribute to fix this issue:

  • Set up your dev environment
  • Move to folder sdk/communication/communication-common
  • Update the version of jwt-decode and @types/jwt-decode used in the package.json file in the above folder
  • Run rush update to ensure the new versions gets installed
  • Check the changelog for jwt-encode to understand the breaking changes and make any required edits in the current folder to absorb these changes
  • Run rushx build in current folder to find and fix any build errors in the package due to the upgrade.
  • Send the PR!

@ramya-rao-a ramya-rao-a added the good first issue This issue tracks work that may be a good starting point for a first-time contributor label Jan 18, 2022
@arisaokasaka arisaokasaka mentioned this issue Jan 30, 2022
Merged
3 tasks
@petrsvihlik
Copy link
Contributor

@DominikMe Dominik Messinger FTE The dependency on jwt-deocde was added in this very first mega PR for ACS packages in #11385. Do you recall the reason you went with v2 and not v3 of jwt-deocde?

I think the reason is that the jwt-decode v3 was still in beta by the time the mega PR was submitted. A first stable version was released a week after that.

@petrsvihlik
Copy link
Contributor

fixed by #20133

@xirzec xirzec removed this from the Backlog milestone May 17, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Jun 6, 2022
CodeGen from PR 19224 in Azure/azure-rest-api-specs
70028a8 
Add managedServerDnsAlias to readme file (Azure#19224)

Co-authored-by: Stefan Krivokapic <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Jun 6, 2022
CodeGen from PR 19333 in Azure/azure-rest-api-specs
e45b021 
Revert "Add managedServerDnsAlias to readme file (Azure#19224)" (Azure#19333)

This reverts commit fada264d1744483dff8242026ed0984ccaa4ae5b.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xirzec @jeremymeng @petrsvihlik @ramya-rao-a @azure-sdk