Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency package @rollup/plugin-commonjs has a new version available #19156

Closed
azure-sdk opened this issue Dec 10, 2021 · 3 comments
Closed

Dependency package @rollup/plugin-commonjs has a new version available #19156

azure-sdk opened this issue Dec 10, 2021 · 3 comments
Assignees
@jeremymeng
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 10, 2021 •
edited by praveenkuttappan
Loading

We have identified a dependency on version 11.0.2 of @rollup/plugin-commonjs. A new version (21.0.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.
  2. Identify all packages that take a dependency on this package.
  3. Go to the root folder for each such package (/sdk/service-name/package-name) and run rush add @rollup/[email protected]
  4. Run rush update to ensure the new version is pulled in.
  5. Make relevant changes to absorb the breaking changes.
  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
This was referenced Dec 13, 2021
Closed
Closed
@jeremymeng
Copy link
Member

latest status from #9066

Currently blocked on an upstream bug in @rollup/plugin-commonjs: rollup/plugins#743

Migrating to rollup 2 and the newer versions of plugin-commonjs will ease the transition to the shared rollup configuration, so this is related to that as well.

@jeremymeng jeremymeng added the EngSys This issue is impacting the engineering system. label Dec 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2021
@praveenkuttappan praveenkuttappan removed the EngSys This issue is impacting the engineering system. label Jan 27, 2022
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Mar 9, 2022
@jeremymeng jeremymeng added the EngSys This issue is impacting the engineering system. label May 5, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue May 25, 2022
CodeGen from PR 19156 in Azure/azure-rest-api-specs
f4d276f 
[Relay] Adding missing success response code to PUT calls on Private Endpoints (Azure#19156)
@jeremymeng
Copy link
Member

current version: v24. Not sure why rush or bot didn't update the latest version. Breaking changes not affecting us: https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md

@jeremymeng
Copy link
Member

already upgraded to v24

@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeremymeng @azure-sdk @praveenkuttappan @witemple-msft