-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter rule to check for existence of the License file #18890
Comments
I am interested in resolving this issue. I think it is viable to check if the contents of |
Fair point. @deyaaeldeen, @witemple-msft, Any thoughts here? |
One idea: @witemple-msft was advocating to use dev-tool to do lint checks on our json files (e.g. package.json and tsconfig.json) because it will be more efficient/natural than using eslint. We could expand on this by making dev-tool also handle existence checks on certain files. To generalize this further, we could make it the entry point to linting (akin to how it handles the new testing stuff now). Since this is a bit complicated, I suggest that @WeiJun428 ignores it for now. @WeiJun428 if you're looking for suggestions on a next issue to work on, #15746 is pretty cool and I think we could use a 3rd party rule for it. |
Turns out this is a check we want to have for other language repos as well. Therefore, we will be having a separate issue Azure/azure-sdk-tools#2353 tracking this requirement such that we add this check in the pipeline instead of linter. Thanks everyone! |
Adding Dynatrace.Observability swagger version 2021-09-01-preview (Azure#18890) * Adding Dynatrace.Observability swagger version 2021-09-01-preview * Fixing spellcheck * Update specification/dynatrace/resource-manager/readme.md * Update readme.python.md * Resolved comments * Adding 401 response in SSO Api Co-authored-by: Yuchao Yan <[email protected]>
All our packages should have a License file with the same content as https://github.com/Azure/azure-sdk-for-js/blob/main/LICENSE
We should have a linter rule that checks for this.
Code pointers:
The text was updated successfully, but these errors were encountered: