Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter rule to check for existence of the License file #18890

Closed
ramya-rao-a opened this issue Nov 30, 2021 · 4 comments
Closed

Linter rule to check for existence of the License file #18890

ramya-rao-a opened this issue Nov 30, 2021 · 4 comments
Labels
eslint plugin feature-request This issue requires a new behavior in the product in order be resolved. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@ramya-rao-a
Copy link
Contributor

All our packages should have a License file with the same content as https://github.com/Azure/azure-sdk-for-js/blob/main/LICENSE
We should have a linter rule that checks for this.

Code pointers:

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 30, 2021
@ramya-rao-a ramya-rao-a added eslint plugin feature-request This issue requires a new behavior in the product in order be resolved. labels Nov 30, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 30, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Nov 30, 2021
@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Nov 30, 2021
@WeiJun428
Copy link
Contributor

I am interested in resolving this issue. I think it is viable to check if the contents of LICENCE is identical, but to my knowledge, there is no way for eslint to check if a file exists. (refer eslint and stackoverflow) May I get suggestions to relevant resources that would be helpful?

@ramya-rao-a
Copy link
Contributor Author

Fair point.

@deyaaeldeen, @witemple-msft, Any thoughts here?

@deyaaeldeen
Copy link
Member

One idea: @witemple-msft was advocating to use dev-tool to do lint checks on our json files (e.g. package.json and tsconfig.json) because it will be more efficient/natural than using eslint. We could expand on this by making dev-tool also handle existence checks on certain files. To generalize this further, we could make it the entry point to linting (akin to how it handles the new testing stuff now).

Since this is a bit complicated, I suggest that @WeiJun428 ignores it for now.

@WeiJun428 if you're looking for suggestions on a next issue to work on, #15746 is pretty cool and I think we could use a 3rd party rule for it.

@ramya-rao-a
Copy link
Contributor Author

Turns out this is a check we want to have for other language repos as well. Therefore, we will be having a separate issue Azure/azure-sdk-tools#2353 tracking this requirement such that we add this check in the pipeline instead of linter.

Thanks everyone!

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue May 10, 2022
Adding Dynatrace.Observability swagger version 2021-09-01-preview (Azure#18890)

* Adding Dynatrace.Observability swagger version 2021-09-01-preview

* Fixing spellcheck

* Update specification/dynatrace/resource-manager/readme.md

* Update readme.python.md

* Resolved comments

* Adding 401 response in SSO Api

Co-authored-by: Yuchao Yan <[email protected]>
@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eslint plugin feature-request This issue requires a new behavior in the product in order be resolved. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Development

No branches or pull requests

4 participants