Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/storage-blob Memory Leak #18117

Closed
6 tasks
himadrinath opened this issue Oct 9, 2021 · 3 comments
Closed
6 tasks

@azure/storage-blob Memory Leak #18117

himadrinath opened this issue Oct 9, 2021 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@himadrinath
Copy link

  • Package Name: @azure/storage-blob
  • Package Version: 12.8.0
  • Operating system: Ubuntu 18.04.3 LTS
  • nodejs
    • version: 14.17.6
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
BlockBlobClient with uploadFile memory increase when uploading and still holding their after upload finished

To Reproduce
Steps to reproduce the behavior:

              await blockBlobClient.uploadFile(fullPath,
                      {
                        blockSize: 4 * 1024 * 1024, // 4MB block size
                        parallelism: 20, // 20 concurrency
                        metadata: {metadata},
                        blobHTTPHeaders: {
                          blobContentType: "video/mp4",
                          blobCacheControl: "public, max-age=31536000",
                        },
                        abortSignal: AbortController.timeout(8 * 60 * 1000),
                        progress: ev => console.log(ev)
                    }).then(result=>{
                    console.log(result)
                    }).catch(error=>{
                    console.log(error)
                    })

Expected behavior
memory should be release after upload complete
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
#4964

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 9, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 10, 2021
@EmmaZhu
Copy link
Member

EmmaZhu commented Oct 12, 2021

Thanks @himadrinath for bringing this to us.

I tried to repro the issue with invoking the method in a long loop, didn't see consistently memory usage increasing. Currently, I'm guessing that this is not a memory leak, it might be caused by GC logic in Node.JS.

I'll do further investigation to see what's in memory, and will update you later.

Thanks
Emma

@EmmaZhu
Copy link
Member

EmmaZhu commented Jan 26, 2022

Hi @himadrinath ,

Did you see consistently memory usage increasing in the operation?

Thanks
Emma

@EmmaZhu EmmaZhu added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Jan 26, 2022
@himadrinath
Copy link
Author

It's resolved it's not because of sdk their is some bug in pm2 cluster mode it's not releasing memory. Thanks

@ghost ghost added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-author-feedback Workflow: More information is needed from author to address the issue. labels Jan 26, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 21, 2022
Review request for Microsoft.ContainerService to add version 2022-02-02-preview (Azure#18150)

* Adds base for updating Microsoft.ContainerService from version preview/2022-01-02-preview to version 2022-02-02-preview

* Updates readme

* Updates API version in new specs and examples

* Add key management service profile of a managed cluster for version 2022-02-02-preview (Azure#17955)

* Add key management service profile of a managed cluster for version 2022-02-02-preview

* add kmsProfile

* update after api review

* add more details in description

* update for comments

* add mc snapshot api (Azure#17974)

* add mc snapshot api

* fix format

* add mc snapshot type

* define type for enums

* add properties for example

* Update readmes for the 2022-02-02-preview dev branch of container service (Azure#17889)

* update readme

* remove useless -only tags

* remove nested property in allOf for 2022-02-02-preview managedClusters (Azure#18063)

* Fix credential format typo in 0102 preview (Azure#18117)

* add missing type object (Azure#18116)

* Update several common definitions according to arm feedback for container service 2022-02-02-preview (Azure#18206)

* update definition of serveral parameters and system data

* update definition of Resource and move property location to sub resources

* add missing tags property for prev Resource

* fix for compatibility

* fix definition name

Co-authored-by: Bin Xia <[email protected]>
Co-authored-by: Qingqing <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants