Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[abort-controller] ship shim d.ts #18049

Closed
jeremymeng opened this issue Oct 5, 2021 · 1 comment
Closed

[abort-controller] ship shim d.ts #18049

jeremymeng opened this issue Oct 5, 2021 · 1 comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Oct 5, 2021

Currently we are packing the following types

    "shims-public.d.ts",
    "types/src",
    "types/3.1",

Now that we have bundled d.ts from api-extractor, we should pack two shim files instead, one for latest and one for the down-leveled.

From Deya in #17986 (comment)

I agree on updating the files list. It includes all files under types in addition to a shim file, so I would suggest to keep the shim and remove types entries. Furthermore, export everything from the d.ts file created by the api extractor from the shim (see here for example). Actually since downlevel types is being used, you will need to have two such shims, one for < v3.6 and another for everything else (see here for example).

As part of this work, also improve consistency with other packages in the repo

  • change sdk/core/abort-controller/tsconfig.json to have
    declarationDir": ".types",
    declarationDir": ".types/latest",
  • adapt to the above changes in sdk/core/abort-controller/package.json and sdk/core/abort-controller/api-extractor.json
@jeremymeng jeremymeng added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Oct 5, 2021
@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Oct 6, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Oct 6, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 15, 2022
Add API version 2022-03-01 to Microsoft.PolicyInsights (Azure#18049)

* Copy 2020-07-01 files

* Add new API version (2022-03-01) to Microsoft.PolicyInsights

The only change is adding support for MG-level calls to the /checkPolicyRestrictions API.

* Fix example title
Copy link

Hi @jeremymeng, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Development

No branches or pull requests

3 participants