-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf Framework] Allow "https" without setting insecure option while using test-proxy #17961
Comments
ManagementPartner: added x-ms-enum for swagger linter (Azure#17961) Co-authored-by: Ochi <[email protected]>
Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support. |
Background
#17898 adds the "insecure" option to create an httpsAgent with
rejectUnauthorized : false
option. Since it is only for testing, we were fine with that.Passing
.pfx
with the passphrase is throwing an error as shown below.This affects both the perf framework and the recorder.
To Repro
azure-sdk-for-js/sdk/test-utils/perfstress/src/utils.ts
Line 28 in 89a29f2
(uncomment the
.pfx
related part in the options)sdk/storage/perf-tests/storage-blob
rush update && rush build -t .
.env
withSTORAGE_CONNECTION_STRING
in the same folderdocker run -p 5000:5000 -p 5001:5001 azsdkengsys.azurecr.io/engsys/ubuntu_testproxy_server:latest
npm run perf-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2
npm run perf-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2 --test-proxy http://localhost:5000
npm run perf-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2 --test-proxy https://localhost:5001
@mikeharder @scbedd @chradek
The text was updated successfully, but these errors were encountered: