Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf Framework] Allow "https" without setting insecure option while using test-proxy #17961

Closed
HarshaNalluru opened this issue Sep 30, 2021 · 1 comment
Assignees
Labels
pillar-performance The issue is related to performance, one of our core engineering pillars.

Comments

@HarshaNalluru
Copy link
Member

Background

#17898 adds the "insecure" option to create an httpsAgent with rejectUnauthorized : false option. Since it is only for testing, we were fine with that.

Passing .pfx with the passphrase is throwing an error as shown below.

image

image

This affects both the perf framework and the recorder.

To Repro

  • Tweak the httpsAgent in
    export const getCachedHttpsAgent = (insecure: boolean) => {

    (uncomment the .pfx related part in the options)
  • Go to sdk/storage/perf-tests/storage-blob
  • rush update && rush build -t .
  • Put .env with STORAGE_CONNECTION_STRING in the same folder
  • In a separate terminal, docker run -p 5000:5000 -p 5001:5001 azsdkengsys.azurecr.io/engsys/ubuntu_testproxy_server:latest
  • Run the test
    • without proxy-tool
      npm run perf-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2
    • with proxy-tool but HTTP
      npm run perf-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2 --test-proxy http://localhost:5000
    • with proxy-tool but https
      npm run perf-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2 --test-proxy https://localhost:5001

@mikeharder @scbedd @chradek

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 30, 2021
@HarshaNalluru HarshaNalluru added this to the Backlog milestone Sep 30, 2021
@HarshaNalluru HarshaNalluru added the pillar-performance The issue is related to performance, one of our core engineering pillars. label Sep 30, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 30, 2021
@HarshaNalluru HarshaNalluru changed the title Allow "https" without setting insecure option while using test-proxy [Perf Framework] Allow "https" without setting insecure option while using test-proxy Sep 30, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 25, 2022
ManagementPartner: added x-ms-enum for swagger linter (Azure#17961)

Co-authored-by: Ochi <[email protected]>
@HarshaNalluru HarshaNalluru removed their assignment Mar 15, 2022
@HarshaNalluru HarshaNalluru modified the milestones: Backlog, [2022] May Mar 15, 2022
@xirzec xirzec modified the milestones: [2022] May, [2022] June May 17, 2022
@timovv timovv modified the milestones: [2022] June, [2022] July Jun 6, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@timovv timovv modified the milestones: 2022-09, Backlog Aug 26, 2022
Copy link

Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
None yet
Development

No branches or pull requests

4 participants