Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Support policy of typescript compiler version #17821

Closed
jeremymeng opened this issue Sep 23, 2021 · 3 comments
Closed

[EngSys] Support policy of typescript compiler version #17821

jeremymeng opened this issue Sep 23, 2021 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 23, 2021

Azure/azure-sdk#1805 (comment)

Just like we came up with the support policy for Node.js versions, we should have one for TypeScript

This item tracks work to gather more data to determine on our support strategy for TSC version.

  • check community usage
  • check major javascript frameworks' requirement, e.g.,
    • Angular
    • React
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Sep 23, 2021
@jeremymeng jeremymeng added this to the [2021] November milestone Sep 23, 2021
@jeremymeng
Copy link
Member Author

jeremymeng commented Nov 9, 2021

Our current NodeJS support is v12 and above. This requires at least TSC v3.7 as the v12 @types/node definitions now use some new syntax:

node_modules/@types/node/assert.d.ts:2:68 - error TS1144: '{' or ';' expected.

2     function assert(value: any, message?: string | Error): asserts value;
                                                                     ~~~~~

node_modules/@types/node/assert.d.ts:53:68 - error TS1144: '{' or ';' expected.

53         function ok(value: any, message?: string | Error): asserts value;
                                                                      ~~~~~

node_modules/@types/node/assert.d.ts:62:94 - error TS1144: '{' or ';' expected.

62         function strictEqual<T>(actual: any, expected: T, message?: string | Error): asserts actual is T;
                                                                                                ~~~~~~
...

@deyaaeldeen
Copy link
Member

Ryan Cavanaugh (TypeScript team) recommends following DefinitelyTyped's two year sliding window since TypeScript itself does not have one.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 28, 2022
@xirzec xirzec modified the milestones: [2022] April, [2022] June May 17, 2022
@xirzec xirzec modified the milestones: [2022] June, [2022] July Jun 13, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@xirzec xirzec modified the milestones: 2022-09, 2022-12 Nov 1, 2022
@xirzec
Copy link
Member

xirzec commented Nov 7, 2022

Closing as duplicate of #19843

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

4 participants