Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Twins - use shared roll up config from dev-tool #17814

Closed
1 task
jeremymeng opened this issue Sep 23, 2021 · 0 comments · Fixed by #19012
Closed
1 task

Digital Twins - use shared roll up config from dev-tool #17814

jeremymeng opened this issue Sep 23, 2021 · 0 comments · Fixed by #19012
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 23, 2021

For the following libraries

  • digitaltwins/digital-twins-core

The Azure SDK for JS repository uses rollup in order to produce browser bundles.
Historically, every package contained its own rollup configuration files when building a browser bundle for testing.

We have an effort in place to share rollup configuration across packages from a common source.

What to do:

  1. Delete rollup.base.config.js and rollup.test.config.js
  2. Update rollup.config.js to the following:
  
import { makeConfig } from "@azure/dev-tool/shared-config/rollup";

export default makeConfig(require("./package.json"));

See the original PR for the shared configuration for an example of how this was done for another package.

  1. Run rushx test from the package folder after setting up your environment

Acceptance criteria:

  • rushx test succeeds
  • rollup.base.config.js and rollup.test.config.js are removed from the relevant directories
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2021
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Sep 23, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2021
@jeremymeng jeremymeng added this to the [2021] November milestone Sep 23, 2021
@maorleger maorleger self-assigned this Dec 8, 2021
maorleger added a commit that referenced this issue Dec 9, 2021
## What

- Fix incorrect logic when suppressing chai's circular dependency warnings
- Move to the common dev-tool configuration where possible

## Why

This is a longstanding issue that we have, where an incorrect logic was copy-pasted to other places. I figured while cleaning this up that any package I touch can just convert over to the shared dev-tool configuration. Where I was unable
to do that, I just fixed this bug to avoid too many changes in one PR.

Fixes #14292
Resolves #17818 
Resolves #17816 
Resolves #17815 
Resolves #17814 
Resolves #17813 
Resolves #17810
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 14, 2022
New review request for Microsoft.ContainerService to add version 2022-01-01 (Azure#17814)

* Adds base for updating Microsoft.ContainerService from version stable/2021-10-01 to version 2022-01-01

* Updates readme

* Updates API version in new specs and examples

* Update readme to help generate SDK (Azure#17371)

* update readme to help generate SDK

* update readme

* Support query parameter 'format' in listClusterUserCredential handler (Azure#17209)

* Support query parameter 'format' in listClusterUserCredential handler

* Add kubelogin to custom words

* Fix enum lint

* Fix typo

* Fix typo

* List admin credential should not have format parameter

* Add adminUsers in aadprofile (Azure#17402)

* Revert "Add adminUsers in aadprofile (Azure#17402)" (Azure#17523)

This reverts commit 1d8f262848ad55df67f60321e2ccc1232c7f746b.

* fix conflict (Azure#17623)

Co-authored-by: Tongyao Si <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants