Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Move all packages to use the shared rollup configuration from dev-tool #17807

Closed
jeremymeng opened this issue Sep 23, 2021 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Epic

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 23, 2021

(adopted from KV tracking issue)

The Azure SDK for JS repository uses rollup in order to produce browser bundles.
Historically, every package contained its own rollup configuration files when building a browser bundle for testing.

We have an effort in place to share rollup configuration across packages from a common source.

What to do:

  1. Delete rollup.base.config.js and rollup.test.config.js
  2. Update rollup.config.js to the following:
  
import { makeConfig } from "@azure/dev-tool/shared-config/rollup";

export default makeConfig(require("./package.json"));

See the original PR for the shared configuration for an example of how this was done for another package.

  1. Run rushx test from the package folder after setting up your environment

Acceptance criteria:

  • rushx test succeeds
  • rollup.base.config.js and rollup.test.config.js are removed from the relevant directories
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Sep 23, 2021
@jeremymeng jeremymeng added this to the [2021] November milestone Sep 23, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 1, 2022
Dev desktopvirtualization microsoft.desktop virtualization 2022 02 10 preview (Azure#17807)

* Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-09-03-preview to version 2022-02-10-preview

* Updates readme

* Updates API version in new specs and examples

* add agent update properties

* change parameter length restrictions

* fix identifiers

* change mininum for scaling

* - added new enum values for hostpool
- added the read only collection array of private endpoint connections
   to hostpool & workspace

* friendly name

* remove length requiremetns

* split patch properties

Co-authored-by: Paul McDaniel <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Epic
Projects
None yet
Development

No branches or pull requests

3 participants