Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-util] Unduplicate "delay" method in core-http and core-amqp through core-util #15930

Closed
HarshaNalluru opened this issue Jun 23, 2021 · 0 comments
Closed

[core-util] Unduplicate "delay" method in core-http and core-amqp through core-util #15930

HarshaNalluru opened this issue Jun 23, 2021 · 0 comments
Assignees
@minhanh-phan
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Jun 23, 2021 •
edited
Loading

#15832 (comment)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 23, 2021
@HarshaNalluru HarshaNalluru mentioned this issue Jun 23, 2021
Merged
@HarshaNalluru HarshaNalluru changed the title [core-util] Unduplicate delay method in core-http and core-amqp [core-util] Unduplicate "delay" method in core-http and core-amqp through core-util Jun 23, 2021
@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Jun 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 24, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 24, 2021
@minhanh-phan minhanh-phan self-assigned this Aug 22, 2022
@minhanh-phan minhanh-phan mentioned this issue Aug 26, 2022
Merged
2 tasks
ghost pushed a commit that referenced this issue Sep 9, 2022
@minhanh-phan
[core-util] Update "delay" method in core-util with abort options (#2…
a6e366d 
…3019)

### Packages impacted by this PR
core-util

### Issues associated with this PR
#15930 

### Describe the problem that is addressed by this PR
- Update "delay" in core-util to support abort message
- Unduplicate "delay" function in core-http and core-amqp

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
- Choose the implementation with "options" parameters to keep the flexibility in case we want to add extra functionality in the future 

### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_
#15832

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
@xirzec xirzec removed this from the Backlog milestone Jan 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@minhanh-phan minhanh-phan

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xirzec @HarshaNalluru @ramya-rao-a @minhanh-phan