Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples for core-rest-pipeline #15013

Closed
YoDaMa opened this issue Apr 24, 2021 · 3 comments · Fixed by #15187
Closed

samples for core-rest-pipeline #15013

YoDaMa opened this issue Apr 24, 2021 · 3 comments · Fixed by #15187
Assignees
@jeremymeng
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs
Milestone
[2021] July

Comments

@YoDaMa
Copy link
Contributor

YoDaMa commented Apr 24, 2021

Is your feature request related to a problem? Please describe.

The @azure/core-rest-pipeline folder does not currently have any samples.

Describe the solution you'd like

A sample outlining how to create a simple request object, send the request, and handle the response.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 24, 2021
@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Apr 26, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 26, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] June milestone Apr 26, 2021
@deyaaeldeen
Copy link
Member

@YoDaMa thanks for opening this issue. Using core-rest-pipeline directly is discouraged because its public surface changes a lot. @azure/core-client uses it which itself is used as the basis for clients in our packages.

Could you please tell me more about your needs and what are you trying to do so we can help better?

@jeremymeng
Copy link
Member

I did an PR earlier #15187 but it's pity that we don't have a real public Azure service endpoint to use in the sample.

@deyaaeldeen deyaaeldeen modified the milestones: [2021] June, [2021] July Jun 9, 2021
@deyaaeldeen deyaaeldeen mentioned this issue Jun 9, 2021
Merged
@deyaaeldeen
Copy link
Member

I followed up with @YoDaMa offline. He is unblocked and @jeremymeng's #15187 should be good enough to resolve this issue.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jul 5, 2021
CodeGen from PR 15013 in Azure/azure-rest-api-specs
a8b9c73 
[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2021-03-01 (Azure#15013)

* Address missing defaults noted by s360

* Update to remove default of array of objects that failed to validate.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[core-rest-pipeline] Add a simple sample jeremymeng/azure-sdk-for-js
4 participants
@deyaaeldeen @jeremymeng @YoDaMa @ramya-rao-a