Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the verify-samples template #14893

Closed
heaths opened this issue Apr 15, 2021 · 2 comments · Fixed by #14894
Closed

Re-enable the verify-samples template #14893

heaths opened this issue Apr 15, 2021 · 2 comments · Fixed by #14894
Assignees
@heaths
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Apr 15, 2021

After PRs #14892 and Azure/azure-sdk-tools#1559 are merged, re-enable the verify-samples template.
@heaths heaths added the EngSys This issue is impacting the engineering system. label Apr 15, 2021
@heaths heaths self-assigned this Apr 15, 2021
@heaths
Copy link
Member Author

heaths commented Apr 15, 2021

Also for python: Azure/azure-sdk-for-python#18066

@mitchdenny
Copy link
Contributor

JS change was merged to disable.

heaths added a commit to heaths/azure-sdk-for-js that referenced this issue Apr 15, 2021
@heaths
Re-enable verify-samples template
9f3d500 
This reverts commit b301b9c
and fixes Azure#14893.
@heaths heaths mentioned this issue Apr 15, 2021
Merged
heaths added a commit that referenced this issue Apr 15, 2021
@heaths
Re-enable verify-samples template (#14894)
6dca0f2 
This reverts commit b301b9c
and fixes #14893.
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this issue Apr 26, 2021
@heaths @vindicatesociety
Re-enable verify-samples template (Azure#14894)
b3299c0 
This reverts commit b301b9c
and fixes Azure#14893.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable verify-samples template heaths/azure-sdk-for-js
2 participants
@mitchdenny @heaths