Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Migrate to Samples Workflow V2 #14474

Closed
1 task
witemple-msft opened this issue Mar 24, 2021 · 0 comments · Fixed by #19085
Closed
1 task

[identity] Migrate to Samples Workflow V2 #14474

witemple-msft opened this issue Mar 24, 2021 · 0 comments · Fixed by #19085
Assignees
@sadasant
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone
[2022] January

Comments

@witemple-msft
Copy link
Member

This issue is part of the Azure SDK for JavaScript sample quality effort.

The new sample tool (dev-tool samples publish) has been made available to all package maintainers, and we would like to migrate all packages to the new system.

What do I need to do?

This issue is to track migrating all packages within the identity folder to the new layout:

  • identity

There are a few things to do to resolve this issue:

  1. Attempt to follow the steps in the migration guide for each of the packages. Any problems can be reported to me, and I'll be available to assist in getting everything moved over.
  2. Look at Samples Quality Effort Tracking Issue #14180, the main tracking issue for this work, and see if your package has any problems listed in the issue description. We would like to fix all of these issues that we are able to fix as we are migrating samples to the new system.

If for any reason you think that this issue should not apply to this service/package, please get in touch with me so that we can discuss the package's needs.

Thank you!
@witemple-msft witemple-msft added EngSys This issue is impacting the engineering system. Azure.Identity labels Mar 24, 2021
@witemple-msft witemple-msft added this to the [2021] April milestone Mar 24, 2021
@sadasant sadasant modified the milestones: [2021] April, 2021 May, [2021] May, [2021] June Mar 31, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July May 12, 2021
@ramya-rao-a ramya-rao-a modified the milestones: [2021] July, Backlog Jun 15, 2021
@kurtzeborn kurtzeborn added the Client This issue points to a problem in the data-plane of the library. label Oct 18, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] December Nov 9, 2021
@sadasant sadasant mentioned this issue Dec 9, 2021
Merged
sadasant added a commit that referenced this issue Dec 13, 2021
@sadasant
[Identity] Migrated to samples v2 (#19085)
a5289f1 
Followed the migration guide to move Identity to the samples v2: https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide

**Important:** Added the `dependencyOverrides` in order to require `@azure/keyvault-keys` on the samples, since Identity can’t depend on `@azure/keyvault-keys` (it would get recursive).

Fixes #14474
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

[Identity] Migrated to samples v2 sadasant/azure-sdk-for-js
4 participants
@sadasant @ramya-rao-a @kurtzeborn @witemple-msft