Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] [External] MSAL should support Node 8, or we should drop Node 8 support #14374

Closed
sadasant opened this issue Mar 18, 2021 · 2 comments
Closed

[Identity] [External] MSAL should support Node 8, or we should drop Node 8 support #14374

sadasant opened this issue Mar 18, 2021 · 2 comments
Assignees
@sadasant
Labels
Azure.Identity blocking-release Blocks release tracking-external-issue
Milestone
[2021] May

Comments

@sadasant
Copy link
Contributor

sadasant commented Mar 18, 2021 •
edited
Loading

Neither MSAL nor msal-node-extensions are intended to work with Node 8:

Moreover, msal-node-extensions' keytar binary is not compiled for Node 8.

What should we do? Should we ask them to support Node 8? Should we drop Node 8 support?

External issue: AzureAD/microsoft-authentication-library-for-js#3337
@sadasant sadasant added this to the [2021] April milestone Mar 18, 2021
@sadasant sadasant self-assigned this Mar 18, 2021
@sadasant
Copy link
Contributor Author

External issue: AzureAD/microsoft-authentication-library-for-js#3337

@sadasant sadasant modified the milestones: [2021] April, [2021] May Mar 31, 2021
@sadasant sadasant added the blocking-release Blocks release label Apr 5, 2021
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 5, 2021 •
edited
Loading

Node.js 8 testing will be dropped in v2 of @azure/identity package. We will be announcing formal policy on support for Node.js versions that have reached end of life soon.

Meanwhile #15139 updates the readme appropriately.

Closing this issue as there are no further action items.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jun 22, 2021
CodeGen from PR 14374 in Azure/azure-rest-api-specs
c5adfaa 
Create new version of Setting API, adding support in AlertSyncSetting (Azure#14374)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity blocking-release Blocks release tracking-external-issue
Projects
None yet
Milestone
[2021] May
Development

No branches or pull requests
2 participants
@sadasant @ramya-rao-a