Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Test and remove old code paths that avoided 'drain' #13094

Closed
richardpark-msft opened this issue Jan 6, 2021 · 2 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@richardpark-msft
Copy link
Member

There is a code path currently that attempts to avoid draining when in receiveAndDelete mode (code).

 // Action to be performed on the "message" event.
      const onReceiveMessage: OnAmqpEventAsPromise = async (context: EventContext) => {
        // TODO: this appears to be aggravating a bug that we need to look into more deeply.
        // The same timeout+drain sequence should work fine for receiveAndDelete but it appears
        // to cause problems.
        if (this._receiveMode === "peekLock") {
          if (brokeredMessages.length === 0) {

Based on the fixes made in these PRs (#12772, #12908, #13073), I'd like to see if we can still reproduce this. If not, we can remove this workaround.

Orig discussion with @chradek: #13073 (comment)

@richardpark-msft richardpark-msft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jan 6, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] February milestone Jan 7, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 2, 2021
Remove name from pool (Azure#13094)

Co-authored-by: Audunn Baldvinsson <[email protected]>
@richardpark-msft
Copy link
Member Author

There was an additional fix in this area: #15989

It'd still be good to put in a perf/stress test for this that to see if this code can be eliminated altogether.

Copy link

Hi @richardpark-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
Status: Done
Development

No branches or pull requests

5 participants