Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Enable build samples #12969

Closed
sadasant opened this issue Dec 17, 2020 · 3 comments
Closed

[Identity] Enable build samples #12969

sadasant opened this issue Dec 17, 2020 · 3 comments
Assignees
@KarishmaGhiya
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@sadasant
Copy link
Contributor

sadasant commented Dec 17, 2020 •
edited
Loading

Our effort to make the identity samples more standard produced other issues with rush. See this PR: #12800

We should enable samples again.

Here’s an example of migrating to Samples v2 on Event Hubs #15053

A challenge we have is that, the samples we should test are really hard to test through automation, because specific identities require specific environments to work, like specific environment variables, network endpoints and sometimes a browser. This remains a hard problem to solve across languages.
@sadasant sadasant added this to the [2021] January milestone Dec 17, 2020
@sadasant sadasant self-assigned this Dec 17, 2020
@sadasant sadasant mentioned this issue Dec 17, 2020
Merged
@sadasant
Copy link
Contributor Author

This won't be possible for February.

@sadasant
Copy link
Contributor Author

sadasant commented Feb 9, 2021

Let's push this to April's milestone.

@sadasant sadasant modified the milestones: [2021] March, [2021] April Feb 9, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 9, 2021
CodeGen from PR 12969 in Azure/azure-rest-api-specs
e97b038 
[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 (Azure#12969)

* Microsoft.DevTestLabs - Fix OpenApi Spec Correctness and Completeness Issues

* Fix ResourceGroup Token

* Remove Unreferenced Example

* Fix Prettier Issues

* Remove generated list api for service runners
@sadasant sadasant modified the milestones: [2021] April, [2021] May Mar 15, 2021
@sadasant sadasant modified the milestones: [2021] May, [2021] June Apr 12, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July May 12, 2021
@ramya-rao-a ramya-rao-a modified the milestones: [2021] July, Backlog Jun 15, 2021
@sadasant sadasant removed their assignment May 9, 2022
@scottaddie scottaddie added the Client This issue points to a problem in the data-plane of the library. label Jan 18, 2023
@github-actions GitHub Actions
Copy link

Hi @sadasant, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sadasant @xirzec @KarishmaGhiya @scottaddie @ramya-rao-a