-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addTelemetryProcessor no longer exported by AzureMonitorTraceExporter #12856
Comments
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @sameergMS, @dadunl. Issue Details
Describe the bug
To Reproduce
Expected behavior
|
This feature was deprecated and removed at the request of the monitor team. |
This is unacceptable and makes this entirely unusable. The documentation
and everyone in the preview team chat was told to use this to set their
role name and customize outgoing data. What's the replacement mechanism for
this?
Can someone from the monitor team please reach out, I've been trying to
ship this for months and it feels like every step you guys take is a step
backwards. Nobody appears to be advocating for the basic needs
consumers/customers.
…On Thu, Dec 10, 2020, 10:41 PM Jeff Fisher ***@***.***> wrote:
This feature was deprecated and removed at the request of the monitor team.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12856 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEMKB3EGDRQNJWAIPF5JLSUGIF3ANCNFSM4UVQ3O3Q>
.
|
To provide a small update: I am talking to the service team about this issue to better understand what needs to be done here. Clearly, there has been some miscommunication. I will update again once it is clear what needs to be done to fix this scenario. |
Circling back to this thread, I am still working to chase down the appropriate owner for resolving this scenario gap. Unfortunately, due to folks being on holiday it may take a bit longer to address. I'll check back again on Monday if nobody from the Monitor side is able to comment before then. |
My understanding is that this feature is being replaced by the work specified in #12880, but I'll let @hectorhdzg confirm. |
We are updating ApplicationInsights role properties logic to align with OpenTelemetry specification, the exporter would read service resource to populate this field and will not be adding "Node.js" anymore, more info regarding OpenTelemetry resources here If resource is not provided roleName and roleInstance would be empty by default. |
We are not adding support for telemetry processors in Azure Monitor Exporter, this is out of scope of the exporter and similar functionalities could be achieved using Resources SDK https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md and SpanProcessors https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#span-processor, let us know if some scenario is not covered so we can address it in OpenTelemetry SDK side. |
@microsoft/opentelemetry-exporter-azure-monitor
#master
Describe the bug
addTelemetryProcessor
is no longer available as indicated in the documentation.To Reproduce
Steps to reproduce the behavior:
Expected behavior
addTelemetryProcessor
is still exported, as it was the only exposed method to adjust outgoing telemetry and to set the rolename (which was hardcoded toNode.js
) -- preview customers were instructed to use this hook and it has been removed.The text was updated successfully, but these errors were encountered: