Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addTelemetryProcessor no longer exported by AzureMonitorTraceExporter #12856

Closed
jmealo opened this issue Dec 10, 2020 · 8 comments
Closed

addTelemetryProcessor no longer exported by AzureMonitorTraceExporter #12856

jmealo opened this issue Dec 10, 2020 · 8 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@jmealo
Copy link

jmealo commented Dec 10, 2020

  • Package Name:
    @microsoft/opentelemetry-exporter-azure-monitor
  • Package Version:
    #master

Describe the bug
addTelemetryProcessor is no longer available as indicated in the documentation.

azureMonitorExporter.addTelemetryProcessor((envelope) => {
                       ^
TypeError: azureMonitorExporter.addTelemetryProcessor is not a function

To Reproduce
Steps to reproduce the behavior:

  1. Hand build a .tgz from the master branch
  2. Install the .tgz

Expected behavior
addTelemetryProcessor is still exported, as it was the only exposed method to adjust outgoing telemetry and to set the rolename (which was hardcoded to Node.js) -- preview customers were instructed to use this hook and it has been removed.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 10, 2020
@xirzec xirzec added Monitor Monitor, Monitor Ingestion, Monitor Query Service Attention Workflow: This issue is responsible by Azure service team. labels Dec 11, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 11, 2020
@ghost
Copy link

ghost commented Dec 11, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @sameergMS, @dadunl.

Issue Details
  • Package Name:
    @microsoft/opentelemetry-exporter-azure-monitor
  • Package Version:
    #master

Describe the bug
addTelemetryProcessor is no longer available as indicated in the documentation.

azureMonitorExporter.addTelemetryProcessor((envelope) => {
                       ^
TypeError: azureMonitorExporter.addTelemetryProcessor is not a function

To Reproduce
Steps to reproduce the behavior:

  1. Hand build a .tgz from the master branch
  2. Install the .tgz
  3. Use that instead of a build published to npm

Expected behavior
addTelemetryProcessor is still exported

Author: jmealo
Assignees: -
Labels:

Monitor, Service Attention, customer-reported, needs-triage, question

Milestone: -

@xirzec
Copy link
Member

xirzec commented Dec 11, 2020

This feature was deprecated and removed at the request of the monitor team.

@jmealo
Copy link
Author

jmealo commented Dec 11, 2020 via email

@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Dec 11, 2020
@xirzec
Copy link
Member

xirzec commented Dec 11, 2020

To provide a small update: I am talking to the service team about this issue to better understand what needs to be done here. Clearly, there has been some miscommunication. I will update again once it is clear what needs to be done to fix this scenario.

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Dec 11, 2020
@xirzec
Copy link
Member

xirzec commented Dec 11, 2020

Circling back to this thread, I am still working to chase down the appropriate owner for resolving this scenario gap. Unfortunately, due to folks being on holiday it may take a bit longer to address. I'll check back again on Monday if nobody from the Monitor side is able to comment before then.

@xirzec
Copy link
Member

xirzec commented Dec 14, 2020

My understanding is that this feature is being replaced by the work specified in #12880, but I'll let @hectorhdzg confirm.

@hectorhdzg
Copy link
Member

We are updating ApplicationInsights role properties logic to align with OpenTelemetry specification, the exporter would read service resource to populate this field and will not be adding "Node.js" anymore, more info regarding OpenTelemetry resources here

If resource is not provided roleName and roleInstance would be empty by default.

@hectorhdzg
Copy link
Member

We are not adding support for telemetry processors in Azure Monitor Exporter, this is out of scope of the exporter and similar functionalities could be achieved using Resources SDK https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md and SpanProcessors https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#span-processor, let us know if some scenario is not covered so we can address it in OpenTelemetry SDK side.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor Monitor, Monitor Ingestion, Monitor Query needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

5 participants