Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage-file-datalake] Fix the rename/move method to support sas in both source and destination #12758

Closed
ljian3377 opened this issue Dec 3, 2020 · 1 comment · Fixed by #12769
Closed

[storage-file-datalake] Fix the rename/move method to support sas in both source and destination #12758

ljian3377 opened this issue Dec 3, 2020 · 1 comment · Fixed by #12769
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Milestone
[2021] January

Comments

@ljian3377
Copy link
Member

Need to provide a SAS for the x-ms-rename-source. For the case below, you can use the same SAS that you used in the URI (“x-ms-rename-source header: {path}?{sas}”).

"request": {
    "streamResponseBody": false,
    "url": "https://url?sasToken&mode=legacy",
    "method": "PUT",
    "headers": {
        "x-ms-rename-source": {
          "name": "x-ms-rename-source",
          "value": "/bugbash/keytarTest2"
        },

And there is some logic to avoid re-encoding the destination in .NET. Make sure we get it right.
https://github.com/Azure/azure-sdk-for-net/blob/dfbc7aa9ee5f053d2d84f85d4d142152886f53ed/sdk/storage/Azure.Storage.Files.DataLake/src/DataLakePathClient.cs#L1679
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 3, 2020
@ljian3377 ljian3377 added the Storage Storage Service (Queues, Blobs, Files) label Dec 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 3, 2020
@ljian3377 ljian3377 added the Client This issue points to a problem in the data-plane of the library. label Dec 3, 2020
@ljian3377 ljian3377 added this to the [2021] January milestone Dec 3, 2020
@JasonYeMSFT JasonYeMSFT mentioned this issue Dec 3, 2020
Merged
@ljian3377
Copy link
Member Author

Fixed by #12769

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 4, 2021
@sgchris
CodeGen from PR 12758 in Azure/azure-rest-api-specs
b36d1e2 
Added missing properties to classic alerts response (Azure#12758)

* added missing properties

* added resource location

* added metricNamespace and provisioningState properties

Co-authored-by: Gregory Chris <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
[2021] January
1 participant
@ljian3377