Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Identity e2e tests for running in Azure Arc #11724

Closed
joshfree opened this issue Oct 8, 2020 · 5 comments · Fixed by #15006
Closed

Create Identity e2e tests for running in Azure Arc #11724

joshfree opened this issue Oct 8, 2020 · 5 comments · Fixed by #15006
Assignees
@sadasant @maorleger
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] May

Comments

@joshfree
Copy link
Member

joshfree commented Oct 8, 2020

Tracking item to create new /sdk/e2e Azure.Identity smoke tests for running in Azure Arc hosted environment.

  1. Add new /sdk/e2e tests for Azure Arc
  2. Update Parent issue Automate Azure Arc testing azure-sdk#1908 with instructions for Test team
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Azure.Identity test enhancement labels Oct 8, 2020
@joshfree joshfree added this to the [2020] November milestone Oct 8, 2020
@sophiajt sophiajt modified the milestones: [2020] November, MQ-2020 Oct 29, 2020
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, [2021] February Nov 16, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Nov 20, 2020
CodeGen from PR 11724 in Azure/azure-rest-api-specs
dc46589 
[T2] devtestlabs for python track2 (Azure#11724)

* python track2

* python
@sadasant
Copy link
Contributor

Moved to March. Time is getting short on February.

@sadasant sadasant modified the milestones: [2021] March, [2021] April Mar 15, 2021
@maorleger maorleger modified the milestones: [2021] April, [2021] May Mar 30, 2021
@sadasant sadasant assigned maorleger and unassigned KarishmaGhiya Apr 19, 2021
@sadasant
Copy link
Contributor

@joshfree I believe that this isn't about automated smoke tests, since we don't have a way to automate tests for these environments. This task is mainly about having written instructions to run a manual test in this environment, is that correct?

@joshfree
Copy link
Member Author

@sadasant yes just open Azure/azure-sdk#1908 and you can port the instructions and test code from one of the other languages to JS for this one

@sadasant
Copy link
Contributor

sadasant commented Apr 19, 2021 •
edited
Loading

@maorleger So, in summary, this issue is about:

  • Manually test Identity (DefaultAzureCredential and ManagedIdentityCredential) in Azure Arc.
  • Write clear instructions on how to create the resource, deploy some testing code, and run the testing code.
  • Put the code and instructions in tests/e2e/azure-arc.
    • There should be a README.md, sample code and a package json.

I wrote some instructions for Azure Arc a while ago. Those should work as a reference: Azure/azure-sdk#1908 (comment)

You can also look at what Python has done: https://github.com/mccoyp/azure-sdk-for-python/tree/master/sdk/identity/azure-identity/tests/managed-identity-live

Java has something more automated, but in case it helps: https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/e2e/src

Regarding how to make these resources:
Other languages have already made resources where to run these manual tests. Reach out to either McCoy Patiño, Catalina Peralta or Vinay Gera for more information.

@sadasant
Copy link
Contributor

Small update: we already have a folder, test/manual-integration. Let's use that one for now!

@maorleger maorleger mentioned this issue Apr 23, 2021
Merged
maorleger added a commit that referenced this issue Apr 23, 2021
@maorleger
[Identity] - Add instructions for running Identity test in Azure Arc (#…
2209bae 
…15006)

This commit adds instructions on how to setup and run an identity smoke test in Azure Arc using managed identity to our collection of manual-integration tests.

Tested manually using a Linux VM

Resolves #11724
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this issue Apr 26, 2021
@maorleger @vindicatesociety
[Identity] - Add instructions for running Identity test in Azure Arc (A…
950abc4 
…zure#15006)

This commit adds instructions on how to setup and run an identity smoke test in Azure Arc using managed identity to our collection of manual-integration tests.

Tested manually using a Linux VM

Resolves Azure#11724
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

@maorleger maorleger

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] May
Development

Successfully merging a pull request may close this issue.

[Identity] - Add instructions for running Identity test in Azure Arc maorleger/azure-sdk-for-js
6 participants
@sadasant @sophiajt @maorleger @joshfree @KarishmaGhiya @ramya-rao-a