Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Digital Twins] Error when paging relationships records #11555

Closed
1 of 6 tasks
jamescarpinter opened this issue Sep 29, 2020 · 3 comments
Closed
1 of 6 tasks

[Digital Twins] Error when paging relationships records #11555

jamescarpinter opened this issue Sep 29, 2020 · 3 comments
Assignees
@zolvarga
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Digital Twins needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@jamescarpinter
Copy link
Contributor

  • Package Name: @azure/digital-twins
  • Package Version: 1.0.0-preview.1
  • Operating system: macOS
  • nodejs
    • version:
  • browser
    • name/version: Chrome 85
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
When a twin has more relationships than can be returned in one page, the SDK automatically fetches the next page using the continuation token. However, from what I can see, the token is passed in the wrong place to the underlying REST SDK which results in an invalid URL being formed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a twin with more than 10 outgoing relationships.
  2. Call the listRelationships method for the twin.

Expected behavior
All relationships should be returned.

Screenshots
N/A

Additional context
See this line. The underlying REST client expects the continuation token as the second parameter but it's passed as the first one. This issue also applies to incoming relationships.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 29, 2020
@jamescarpinter jamescarpinter mentioned this issue Sep 29, 2020
Merged
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Digital Twins labels Sep 29, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2020
@ramya-rao-a ramya-rao-a added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 29, 2020
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @jamescarpinter

@zolvarga, Can you take a look at this issue and the corresponding PR #11556 ?

ramya-rao-a pushed a commit that referenced this issue Oct 15, 2020
@jamescarpinter
Fix ADT relationship paging (#11555) (#11556)
e06b32c
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Nov 24, 2020
CodeGen from PR 11555 in Azure/azure-rest-api-specs
0dd5033 
Add change directory to reservations spec 2020-10-01-preview (Azure#11555)

* Add change directory to reservations spec 2020-10-01-preview

* refactoring and updating description

* prettier and spellcheck

* Revert "prettier and spellcheck"

This reverts commit b2a9735fe4791b6202083c5d4111a2f588b5b947.

* Revert "refactoring and updating description"

This reverts commit 9dfdd7878629eb83a33070712b302bc1fba94f1e.

* Revert "Add change directory to reservations spec 2020-10-01-preview"

This reverts commit 064f7a9f86a72620d123d69a13c23ef8a61c38b7.

* moving change directory to new api version

* fixing lint error

* update default tag

Co-authored-by: Sean Oh <[email protected]>
@ramya-rao-a
Copy link
Contributor

@zolvarga I see that the PR #11556 is merged, but the fix has not been released yet. What are the plans for the release here?

@ramya-rao-a ramya-rao-a added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jan 4, 2021
@ramya-rao-a
Copy link
Contributor

@jamescarpinter The package @azure/digital-twins has been renamed to @azure/digital-twins-core which has since had releases which contain the fix to this issue.

Thanks for reporting and sending the PR

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zolvarga zolvarga

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Digital Twins needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamescarpinter @zolvarga @ramya-rao-a