Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Distributed Tracing features in the new Service Bus library #11465

Closed
ramya-rao-a opened this issue Sep 24, 2020 · 2 comments · Fixed by #11810
Closed

Review Distributed Tracing features in the new Service Bus library #11465

ramya-rao-a opened this issue Sep 24, 2020 · 2 comments · Fixed by #11810
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@ramya-rao-a
Copy link
Contributor

When we were working on the latest Event Hubs package, we had a definite set of requirements of how each send request and the different modes of receiving events did tracing. Service Bus is in a similar boat as Event Hubs in terms of tracing needs with the addition of a whole new set of methods for peek, receiving deferred messages, sending scheduled messages etc.

This issue is to review how much of what we did in Event Hubs can be ported over to Service Bus and figure out the gap

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 24, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Sep 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] November milestone Sep 25, 2020
@jmealo
Copy link

jmealo commented Oct 2, 2020

@ramya-rao-a: this would be super helpful. We're on the preview of the service-bus library and have an issue where our queues stop processing after a number of hours regardless of volume. Since the refactoring of logging to be compatible with IE11, debug no longer works as expected with pino-debug which causes all the Azure logging to side-step our logging facilities and go to std-err as multi-line errors. It's very hard to troubleshoot as the instrumentation seems focused more towards internal/Azure use versus what an end user/customer would actually need to troubleshoot issues.

@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Oct 7, 2020
@richardpark-msft
Copy link
Member

@jmealo - the logging that we internally produce is intended for troubleshooting so it can be quite detailed. The feature above would be a better fit for overall health/monitoring in that it'll give you an idea of how long messages take to go through your processing, etc...

However, a dead receiver is different - this should have triggered an error or message that would have shown up as an exception, or delivered via your processError callback.

Please feel free to file an issue and we can take a look.

Things we'll need to start:

  • Any logs you can collect - obviously the window of time when it's no longer working and the period before to see if there were issues with the connection to the service bus broker, etc..
  • Any information about your service bus that you can collect that might be related to service disruption
  • Which method do you use to receive messages? Is it subscribe, receiveMessages or getMessageIterator?

The bug report template in the issue tracker for this repo should guide you on some other details when you're ready.

richardpark-msft added a commit that referenced this issue Oct 14, 2020
Adding in tracing for the three receive methods (subscribe, receiveMessages and getMessageIterator) for sessions and non-sessions.

Fixes #11465
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants